linux-kernel - Re: [PATCH] x86/microcode: Add microcode_loader_disabled() storage class for the !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250506121920.GCaBn-SNzAJx3aodZF@fat_crate.local>
Date: Tue, 6 May 2025 14:19:20 +0200
From: Borislav Petkov <bp@...en8.de>
To: Ingo Molnar <mingo@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-tip-commits@...r.kernel.org,
	stable@...nel.org, x86@...nel.org
Subject: Re: [PATCH] x86/microcode: Add microcode_loader_disabled() storage
 class for the !CONFIG_MICROCODE case

On Tue, May 06, 2025 at 12:57:08PM +0200, Ingo Molnar wrote:
> Please don't forcibly rebase trees like that, because you've just 
> reintroduced a bug this way in tip:x86/urgent:
> 
>   # 5214a9f6c0f5 x86/microcode: Consolidate the loader enablement checking
> 
>   +static inline bool __init microcode_loader_disabled(void) { return false; }
> 
> static inlines don't need an __init tag ...

Oh please do tell what kind of bug that is. Especially if in
a CONFIG_MICROCODE=n build *all* the callsites of that function are gone!

Geez.

> Technically the 'int' in 'unsigned int' is 'unnecessary' and could be 
> skipped as well with 'unsigned', right?

And this is the same how exactly?

> Yet clean kernel code uses it because it's easier to read and more
> consistent. Likewise, the 'extern' storage class is a well-known and
> widespread way in the kernel to document public APIs, a counterpart to
> 'static'. Most of our major headers use that style.

Does this header need it?

No. Not really.

If it fixes something, yes, sure, by all means.

Gratuitous cleanups without any point: no. 

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette