linux-kernel - Re: [PATCH v3 2/2] clocksource/drivers/renesas-ostm: Unconditionally enable reprobe support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXbeZPCCxqqU2O3J5K38ygJb2zMbuNq7mD0CCjLEgtPxw@mail.gmail.com>
Date: Tue, 6 May 2025 14:49:55 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Prabhakar <prabhakar.csengg@...il.com>
Cc: Daniel Lezcano <daniel.lezcano@...aro.org>, Thomas Gleixner <tglx@...utronix.de>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Maxime Coquelin <mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>, 
	Geert Uytterhoeven <geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>, 
	Chris Brandt <chris.brandt@...esas.com>, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, 
	linux-arm-kernel@...ts.infradead.org, linux-renesas-soc@...r.kernel.org, 
	Biju Das <biju.das.jz@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH v3 2/2] clocksource/drivers/renesas-ostm: Unconditionally
 enable reprobe support

On Tue, 6 May 2025 at 12:32, Prabhakar <prabhakar.csengg@...il.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
>
> Previously, the OSTM driver's platform probe path was only enabled for
> selected SoCs (e.g., RZ/G2L and RZ/V2H) due to issues on RZ/Ax (ARM32)
> SoCs, which encountered IRQ conflicts like:
>
>     /soc/timer@...3b000: used for clock events
>     genirq: Flags mismatch irq 16. 00215201 (timer@...3c000) vs. 00215201 (timer@...3c000)
>     Failed to request irq 16 for /soc/timer@...3c000
>     renesas_ostm e803c000.timer: probe with driver renesas_ostm failed with error -16
>
> These issues have since been resolved by commit 37385c0772a4
> ("clocksource/drivers/renesas-ostm: Avoid reprobe after successful early
> probe"), which prevents reprobe on successfully initialized early timers.
>
> With this fix in place, there is no longer a need to restrict platform
> probing based on SoC-specific configs. This change unconditionally enables
> reprobe support for all SoCs, simplifying the logic and avoiding the need
> to update the configuration for every new Renesas SoC with OSTM.
>
> RZ/A1 and RZ/A2 remain unaffected with this change.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> ---
> v2->v3:
> - Dropped config check and unconditionally enabled reprobe support for all
>   SoCs.
> - Dropped Reviewed-by tag from Geert

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Boots fine on RSK+RZA1 and RZA2MEVB.

Tested-by: Geert Uytterhoeven <geert+renesas@...der.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds