linux-kernel - Re: [PATCH v12] platform/x86: Add AMD ISP platform config for OV05C10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21c9d764-4945-4837-93dc-ab58f22f8668@linux.intel.com>
Date: Tue, 6 May 2025 15:53:28 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Ilya K <me@...ti.me>
cc: Pratap Nirujogi <pratap.nirujogi@....com>, 
    Hans de Goede <hdegoede@...hat.com>, W_Armin@....de, 
    mario.limonciello@....com, platform-driver-x86@...r.kernel.org, 
    LKML <linux-kernel@...r.kernel.org>, benjamin.chan@....com, bin.du@....com, 
    gjorgji.rosikopulos@....com, king.li@....com, dantony@....com
Subject: Re: [PATCH v12] platform/x86: Add AMD ISP platform config for
 OV05C10

On Tue, 6 May 2025, Ilya K wrote:

> > +#define AMDISP_OV05C10_I2C_ADDR		0x10
> > +#define AMDISP_OV05C10_PLAT_NAME	"amdisp_ov05c10_platform"
> > +#define AMDISP_OV05C10_HID		"OMNI5C10"
> > +#define AMDISP_OV05C10_REMOTE_EP_NAME	"ov05c10_isp_4_1_1"
> > +#define AMD_ISP_PLAT_DRV_NAME		"amd-isp4"
> 
> Hey folks, I know v12 might be a bit too late for this one, but I've got 
> another device here (Asus GZ302EA tablet) with a very similar camera 
> setup, but a different sensor (OV13B10), and it looks like this driver 
> just assumes a certain hardcoded configuration... I wonder if it makes 
> sense to reorganize the code so that more sensor configurations can be 
> added without making a separate module? I'd be happy to help with 
> refactoring/testing/etc, if people are interested.

v12 is not too late, and besides, v9..v12 has happened within 5 days 
which is rather short time (hint to the submitter that there's no need 
to burn patch series version numbers at that speed :-)).

I'll give folks some time to sort this out if you need to add e.g., some 
driver_data instead.

-- 
 i.