linux-kernel - Re: [PATCH] power: reset: POWER_RESET_TORADEX_EC should depend on ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <091539c4-8ed1-46a4-aab5-8eb0e62a9027@gmail.com>
Date: Tue, 6 May 2025 15:23:00 +0200
From: Emanuele Ghidoli <ghidoliemanuele@...il.com>
To: Geert Uytterhoeven <geert+renesas@...der.be>,
 Sebastian Reichel <sre@...nel.org>,
 Emanuele Ghidoli <emanuele.ghidoli@...adex.com>,
 Francesco Dolcini <francesco.dolcini@...adex.com>
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: reset: POWER_RESET_TORADEX_EC should depend on
 ARCH_MXC

On 06/05/2025 15:01, Geert Uytterhoeven wrote:
> The Toradex Embedded Controller is currently only present on Toradex
> SMARC iMX8MP and iMX95 SoMs.  Hence add a dependency on ARCH_MXC, to
> prevent asking the user about this driver when configuring a kernel
> without NXP i.MX SoC family support.
> 
> Fixes: 18672fe12367ed44 ("power: reset: add Toradex Embedded Controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>  drivers/power/reset/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> index 5ce402ff71964f59..1a17c5192818de1e 100644
> --- a/drivers/power/reset/Kconfig
> +++ b/drivers/power/reset/Kconfig
> @@ -218,6 +218,7 @@ config POWER_RESET_ST
>  
>  config POWER_RESET_TORADEX_EC
>  	tristate "Toradex Embedded Controller power-off and reset driver"
> +	depends on ARCH_MXC || COMPILE_TEST
>  	depends on I2C
>  	select REGMAP_I2C
>  	help

The default is 'N', and the EC is just an I2C device, unrelated to ARCH_MXC.
Is it really annoying if the user is asked about this driver during
configuration? Or is it just normal?
Wouldn't there be a better way to handle this?