linux-kernel - Re: [PATCH v2 6/6] of: of_cpu_phandle_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48fd85e7-4940-4bfd-943d-3c9674828a6c@kernel.org>
Date: Tue, 6 May 2025 15:36:05 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Alireza Sanaee <alireza.sanaee@...wei.com>
Cc: devicetree@...r.kernel.org, robh@...nel.org, jonathan.cameron@...wei.com,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linuxarm@...wei.com, mark.rutland@....com,
 shameerali.kolothum.thodi@...wei.com
Subject: Re: [PATCH v2 6/6] of: of_cpu_phandle_to_id to support SMT threads

On 06/05/2025 15:31, Alireza Sanaee wrote:
>>>>  
>>>
>>> Hi Krzysztof,
>>>
>>> There are some existing bindings in which this pattern has been
>>> used, so I don't think I am changing binding really.
>>>
>>> https://www.kernel.org/doc/Documentation/devicetree/bindings/thermal/thermal-zones.yaml#:~:text=cooling%2Ddevice%20%3D%20%3C%26CPU0%203%203%3E%2C%20%3C%26CPU1%203%203%3E%2C  
>> I do not understand this - it is not cpus phandle. Please respond to
>> specific comment: how many arguments are allowed by dtschema for cpus?
> 
> Hi Krzysztof,
> 
> If you mean checking
> here? https://github.com/devicetree-org/dt-schema/blob/e6ea659d2baa30df1ec0fcc4f8354208692489eb/dtschema/schemas/cpu-map.yaml#L110
> 
> There is no parameters allowed at this point for cpu phandles in the
> cpu-map tree. Of course, this is different than what's been
> implemented in the patchset.
Hm, ok, I thought you are adding this for cpu-map, but if not, then
where are the bindings for this ABI?

BTW, share your DTS so we can be sure that it is properly validated
against bindings.

Best regards,
Krzysztof