linux-kernel - Re: [PATCH] platform/x86/amd/pmc: Declare quirk_spurious

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c355c40-defa-4486-a89a-39f1ad3aba03@aosc.io>
Date: Tue, 6 May 2025 22:02:19 +0800
From: Mingcong Bai <jeffbai@...c.io>
To: Mario Limonciello <mario.limonciello@....com>, Runhua He <hua@...c.io>,
 platform-driver-x86@...r.kernel.org
Cc: Rong Zhang <i@...g.moe>, Kexy Biscuit <kexybiscuit@...c.io>,
 Xinhui Yang <cyan@...no.uk>, Yemu Lu <prcups@...m.moe>,
 Shyam Sundar S K <Shyam-sundar.S-k@....com>,
 Hans de Goede <hdegoede@...hat.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86/amd/pmc: Declare quirk_spurious_8042 for
 MECHREVO Wujie 14XA (GX4HRXL)

Hi Mario,

在 2025/5/6 21:29, Mario Limonciello 写道:
> On 5/6/2025 6:25 AM, Runhua He wrote:
>> MECHREVO Wujie 14XA (GX4HRXL) wakes up immediately after s2idle entry.
>> This happens regardless of whether the laptop is plugged into AC power,
>> or whether any peripheral is plugged into the laptop.
>>
>> Similar to commit a55bdad5dfd1 ("platform/x86/amd/pmc: Disable keyboard
>> wakeup on AMD Framework 13"), the MECHREVO Wujie 14XA wakes up almost
>> instantly after s2idle suspend entry (IRQ1 is the keyboard):
>>
>> 2025-04-18 17:23:57,588 DEBUG:  PM: Triggering wakeup from IRQ 9
>> 2025-04-18 17:23:57,588 DEBUG:  PM: Triggering wakeup from IRQ 1
>>
>> Add this model to the spurious_8042 quirk to workaround this.
>>
>> This patch does not affect the wake-up function of the built-in keyboard.
>> Because the firmware of this machine adds an insurance for keyboard
>> wake-up events, as it always triggers an additional IRQ 9 to wake up the
>> system.
>>
>> I have only matched the motherboard model, as the same chassis and
>> motherboard (GX4HRXL) combination may be used under different product
>> names.
>>
>> Suggested-by: Mingcong Bai <jeffbai@...c.io>
>> Suggested-by: Xinhui Yang <cyan@...no.uk>
>> Suggested-by: Rong Zhang <i@...g.moe>
>> Fixes: a55bdad5dfd1 ("platform/x86/amd/pmc: Disable keyboard wakeup on 
>> AMD Framework 13")
>> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4166
>> Cc: Mario Limonciello <mario.limonciello@....com>
>> Link: https://zhuanldan.zhihu.com/p/730538041
>> Tested-by: Yemu Lu <prcups@...m.moe>
>> Signed-off-by: Runhua He <hua@...c.io>
>> ---
>>   drivers/platform/x86/amd/pmc/pmc-quirks.c | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/platform/x86/amd/pmc/pmc-quirks.c b/drivers/ 
>> platform/x86/amd/pmc/pmc-quirks.c
>> index b4f49720c87f..e01012d5ecd0 100644
>> --- a/drivers/platform/x86/amd/pmc/pmc-quirks.c
>> +++ b/drivers/platform/x86/amd/pmc/pmc-quirks.c
>> @@ -217,6 +217,13 @@ static const struct dmi_system_id fwbug_list[] = {
>>               DMI_MATCH(DMI_BIOS_VERSION, "03.05"),
>>           }
>>       },
>> +    {
>> +        .ident = "MECHREVO Wujie 14 Series (GX4HRXL)",
>> +        .driver_data = &quirk_spurious_8042,
>> +        .matches = {
>> +            DMI_MATCH(DMI_BOARD_NAME, "GX4HRXL"),
> 
> This feels like it might be too wide.  Could we match a system vendor as 
> well?

Possibly. There are two known system vendors using this motherboard - 
TongFang and MECHREVO (MECHREVO is a marque owned by TongFang).

See: https://linux-hardware.org/?probe=6783d8fc06

Runhua, maybe we could make two entries here?

Best Regards,
Mingcong Bai