linux-kernel - Re: [PATCH 6/7] rtc: s3c: drop unused module alias

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <193c2c8c-df64-43ab-84ef-5e981fc31469@kernel.org>
Date: Tue, 6 May 2025 16:19:08 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Johan Hovold <johan+linaro@...nel.org>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc: Nicolas Ferre <nicolas.ferre@...rochip.com>,
 Claudiu Beznea <claudiu.beznea@...on.dev>,
 Paul Cercueil <paul@...pouillou.net>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Sebastian Reichel <sre@...nel.org>, linux-rtc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/7] rtc: s3c: drop unused module alias

On 23/04/2025 15:03, Johan Hovold wrote:
> The driver only support OF probe so drop the unused platform module
> alias.
> 
> Fixes: ae05c95074e0 ("rtc: s3c: add s3c_rtc_data structure to use variant data instead of s3c_cpu_type")

I believe this is not correct, but instead commit dropping last platform
user, which I think was:

Fixes: 0d297df03890 ("ARM: s3c: simplify platform code")


Just like in other patches here, these are old drivers and even if they
have OF matching method, they can be or they were modprobed via board files.

> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> ---


With the fixes tag fixed (to whatever commit dropping last platform user):

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof