[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250506-supply-machine-ad65dbc84cb7@spud>
Date: Tue, 6 May 2025 17:19:01 +0100
From: Conor Dooley <conor@...nel.org>
To: Jianping.Shen@...bosch.com
Cc: jic23@...nel.org, lars@...afoo.de, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, dima.fedrau@...il.com,
marcelo.schmitt1@...il.com, linux-iio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Christian.Lorenz3@...bosch.com, Ulrike.Frauendorf@...bosch.com,
Kai.Dolde@...bosch.com
Subject: Re: [PATCH v1 2/3] dt-bindings: iio: imu: smi330: Add binding
On Mon, May 05, 2025 at 05:16:40PM +0200, Jianping.Shen@...bosch.com wrote:
> From: Jianping Shen <Jianping.Shen@...bosch.com>
>
> Add devicetree binding for Bosch imu smi330.
> The smi330 is a combined three axis angular rate and
> three axis acceleration sensor module.
>
> Signed-off-by: Jianping Shen <Jianping.Shen@...bosch.com>
> ---
> .../bindings/iio/imu/bosch,smi330.yaml | 89 +++++++++++++++++++
> 1 file changed, 89 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/imu/bosch,smi330.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/imu/bosch,smi330.yaml b/Documentation/devicetree/bindings/iio/imu/bosch,smi330.yaml
> new file mode 100644
> index 00000000000..fb65bd26ada
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/imu/bosch,smi330.yaml
> @@ -0,0 +1,89 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/imu/bosch,smi330.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Bosch SMI330 6-Axis IMU
> +
> +maintainers:
> + - Stefan Gutmann <stefam.gutmann@...bosch.com>
> +
> +description:
> + SMI330 is a 6-axis inertial measurement unit that supports acceleration and
> + gyroscopic measurements with hardware fifo buffering. Sensor also provides
> + events information such as motion, no-motion and tilt detection.
> +
> +properties:
> + compatible:
> + const: bosch,smi330
> +
> + reg:
> + maxItems: 1
> +
> + vdd-supply:
> + description: provide VDD power to the sensor.
> +
> + vddio-supply:
> + description: provide VDD IO power to the sensor.
> +
> + interrupts:
> + minItems: 1
> + maxItems: 2
> +
> + interrupt-names:
> + minItems: 1
> + maxItems: 2
> + items:
> + enum:
> + - INT1
> + - INT2
> +
> + drive-open-drain:
This property is missing a type, no? boolean or flag
> + description:
> + set if the specified interrupt pin should be configured as
> + open drain. If not set, defaults to push-pull.
What "specified interrupt pin"? You've got two interrupts, does this
apply to one? Both?
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists