linux-kernel - Re: [PATCH v9] media: vsp1: Add VSPX support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250506173733.GA539397@ragnatech.se>
Date: Tue, 6 May 2025 19:37:33 +0200
From: Niklas Söderlund <niklas.soderlund@...natech.se>
To: Jacopo Mondi <jacopo.mondi+renesas@...asonboard.com>
Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
	linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v9] media: vsp1: Add VSPX support

Hi Jacopo,

Thanks for this new version!

I will give this a good testing as soon as I have finished some 
refactoring of the user of this. I had a comment I wanted to send for 
v8, but seems I never did. So for now I will just post this incase you 
need to do a v10 before I had time.

On 2025-05-06 18:32:23 +0200, Jacopo Mondi wrote:

.. snip ..

> +struct vsp1_dl_list;
> +struct vsp1_isp_job_desc {
> +	struct {
> +		unsigned int pairs;
> +		dma_addr_t mem;
> +	} config;
> +	struct {
> +		struct v4l2_format fmt;

I'm very happy to see this is now the only location for the format, nice 
work! I wonder if we shall take it one step further and just record the 
fourcc, width, height and bytesperline here? Or at switch to a 
v4l2_pix_format struct?

The user of this field do not really support multi plane formats, nor do 
it validate fmt.type field.

I recently hit a snag in the ISP driver using this interface where I 
*think* the solution is to only allow single plane buffers to be used as 
input to the ISP (V4L2_CAP_VIDEO_OUTPUT_MPLANE vs 
V4L2_CAP_VIDEO_OUTPUT). While fixing the plumbing for this I ran across 
this, sorry for not noticing before.

> +		dma_addr_t mem;
> +	} img;
> +	struct vsp1_dl_list *dl;
> +};

-- 
Kind Regards,
Niklas Söderlund