linux-kernel - Re: [PATCH] EISA: Move devlist.h out of obj to always

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202505061150.4B9A78AC13@keescook>
Date: Tue, 6 May 2025 11:51:42 -0700
From: Kees Cook <kees@...nel.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alejandro Colomar <alx@...nel.org>, linux-kernel@...r.kernel.org,
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH] EISA: Move devlist.h out of obj to always

On Tue, May 06, 2025 at 08:54:29AM -0700, Randy Dunlap wrote:
> Hi Kees,
> 
> On 4/22/25 8:50 PM, Randy Dunlap wrote:
> > 
> > 
> > On 4/22/25 7:37 PM, Kees Cook wrote:
> >> I put devlist.h into the wrong Makefile macro ("obj") to get it included
> >> in "targets". Put it into "always" so nothing tries to link against it.
> >> Solves CONFIG_EISA=y i386 build failure:
> >>
> >> ld: vmlinux.a: member drivers/eisa/devlist.h in archive is not an object
> >>
> >> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> >> Closes: https://lore.kernel.org/all/4a8ba1d0-d2d9-41f8-abf1-d45ec8996d10@infradead.org
> >> Fixes: dd09eb0e2cc4 ("EISA: Increase length of device names")
> >> Signed-off-by: Kees Cook <kees@...nel.org>
> > 
> > Acked-by: Randy Dunlap <rdunlap@...radead.org>
> > Tested-by: Randy Dunlap <rdunlap@...radead.org>
> > 
> > Thanks.
> > 
> 
> Please merge this patch. The build failure is killing lots of i386 builds.
> Thanks.

AFAIK, this needs to go via Greg's tree, but I can see if I can send it
to Linus directly.

-Kees

> 
> >> ---
> >> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> >> Cc: Alejandro Colomar <alx@...nel.org>
> >> ---
> >>  drivers/eisa/Makefile | 3 ++-
> >>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/eisa/Makefile b/drivers/eisa/Makefile
> >> index f0d6cf7d1f32..552bd9478340 100644
> >> --- a/drivers/eisa/Makefile
> >> +++ b/drivers/eisa/Makefile
> >> @@ -1,7 +1,8 @@
> >>  # SPDX-License-Identifier: GPL-2.0
> >>  # Makefile for the Linux device tree
> >>  
> >> -obj-$(CONFIG_EISA)	        += devlist.h eisa-bus.o
> >> +always-$(CONFIG_EISA)		+= devlist.h
> >> +obj-$(CONFIG_EISA)	        += eisa-bus.o
> >>  obj-${CONFIG_EISA_PCI_EISA}     += pci_eisa.o
> >>  
> >>  # virtual_root.o should be the last EISA root device to initialize,
> > 
> 
> -- 
> ~Randy
> 

-- 
Kees Cook