linux-kernel - Re: sound/pci/hda: add quirk for HP Spectre x360 15-eb0xxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <87y0v9v9la.wl-tiwai@suse.de>
Date: Tue, 06 May 2025 21:10:41 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Ezra Khuzadi <ekhuzadi@....edu>
Cc: kernel test robot <lkp@...el.com>,
	sound-dev@...r.kernel.org,
	stable@...r.kernel.org,
	oe-kbuild-all@...ts.linux.dev,
	alsa-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org,
	"perex@...ex.cz" <perex@...ex.cz>
Subject: Re: sound/pci/hda: add quirk for HP Spectre x360 15-eb0xxx

On Tue, 06 May 2025 12:11:26 +0200,
Ezra Khuzadi wrote:
> 
> 
> Hi Takashi, Jaroslav, all maintainers,
> 
> Could you please review it or let me know if any changes are needed? This is
> my first kernel patch as a student, and I’d appreciate any feedback.

I guess you submitted to a wrong address.  The proper mailing list is
linux-sound@...r.kernel.org.  Please try to resubmit.
And, make sure that your mailer doesn't break tabs and whitespaces.
You can test sending to yourself and verify that the submitted patch
is properly applicable beforehand.


thanks,

Takashi

> 
> Thanks,
> Ezra Khuzadi
> 
> On Wed, Apr 30, 2025 at 1:43 AM Ezra Khuzadi <ekhuzadi@....edu> wrote:
> 
>     sound/pci/hda/patch_realtek.c: add quirk for HP Spectre x360 15-eb0xxx
>    
>     Add subsystem ID 0x86e5 for HP Spectre x360 15-eb0xxx so that
>     ALC285_FIXUP_HP_SPECTRE_X360_EB1 (GPIO amp-enable, mic-mute LED and
>     pinconfigs) is applied.
>    
>     Tested on HP Spectre x360 15-eb0043dx (Vendor 0x10ec0285, Subsys
>     0x103c86e5)
>     with legacy HDA driver and hda-verb toggles:
>    
>       $ cat /proc/asound/card0/codec#0 \
>           | sed -n -e '1,5p;/Vendor Id:/p;/Subsystem Id:/p'
>       Codec: Realtek ALC285
>       Vendor Id: 0x10ec0285
>       Subsystem Id: 0x103c86e5
>    
>       $ dmesg | grep -i realtek
>       [    5.828728] snd_hda_codec_realtek ehdaudio0D0: ALC285: picked fixup
>             for PCI SSID 103c:86e5
>    
>     Signed-off-by: Ezra Khuzadi <ekhuzadi@....edu>
>     Cc: stable@...r.kernel.org
>    
>     ---
>      sound/pci/hda/patch_realtek.c | 1 +
>      1 file changed, 1 insertion(+)
>    
>     diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>     index 877137cb09ac..82ad105e7fa9 100644
>     --- a/sound/pci/hda/patch_realtek.c
>     +++ b/sound/pci/hda/patch_realtek.c
>     @@ -10563,6 +10563,7 @@ static const struct hda_quirk alc269_fixup_tbl[] =
>     {
>        SND_PCI_QUIRK(0x103c, 0x86c7, "HP Envy AiO 32",
>     ALC274_FIXUP_HP_ENVY_GPIO),
>     +  SND_PCI_QUIRK(0x103c, 0x86e5, "HP Spectre x360 15-eb0xxx",
>     ALC285_FIXUP_HP_SPECTRE_X360_EB1),
>        SND_PCI_QUIRK(0x103c, 0x86e7, "HP Spectre x360 15-eb0xxx",
>     ALC285_FIXUP_HP_SPECTRE_X360_EB1),
>        SND_PCI_QUIRK(0x103c, 0x86e8, "HP Spectre x360 15-eb0xxx",
>     ALC285_FIXUP_HP_SPECTRE_X360_EB1),
>        SND_PCI_QUIRK(0x103c, 0x86f9, "HP Spectre x360 13-aw0xxx",
>     ALC285_FIXUP_HP_SPECTRE_X360_MUTE_LED),
>    
>     On Wed, Apr 30, 2025 at 1:33 AM kernel test robot <lkp@...el.com> wrote:
>     >
>     > Hi,
>     >
>     > Thanks for your patch.
>     >
>     > FYI: kernel test robot notices the stable kernel rule is not satisfied.
>     >
>     > The check is based on 
>     https://urldefense.com/v3/__https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html*option-1__;Iw!!CzAuKJ42GuquVTTmVmPViYEvSg!PiCmDJsbkP48HY6ady0rbC21rGusuY-IjJ61JqQnp99GdHsbc5uEQDwV-Q9TeKK7R4THFV7fXQ$
>     >
>     > Rule: add the tag "Cc: stable@...r.kernel.org" in the sign-off area to
>     have the patch automatically included in the stable tree.
>     > Subject: sound/pci/hda: add quirk for HP Spectre x360 15-eb0xxx
>     > Link: 
>     https://urldefense.com/v3/__https://lore.kernel.org/stable/CAPXr0uxh0c_2b2-zJF*3DN8T6DfccfyvOQRX0X0VO24dS7YsxzzQ*40mail.gmail.com__;JSU!!CzAuKJ42GuquVTTmVmPViYEvSg!PiCmDJsbkP48HY6ady0rbC21rGusuY-IjJ61JqQnp99GdHsbc5uEQDwV-Q9TeKK7R4SyRLIbeQ$
>     >
>     > --
>     > 0-DAY CI Kernel Test Service
>     > 
>     https://urldefense.com/v3/__https://github.com/intel/lkp-tests/wiki__;!!CzAuKJ42GuquVTTmVmPViYEvSg!PiCmDJsbkP48HY6ady0rbC21rGusuY-IjJ61JqQnp99GdHsbc5uEQDwV-Q9TeKK7R4QdTQyPmg$
>     >
>     >
>     >
>