| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <82fd6088-2979-4a4b-8eb5-dd8da965369e@collabora.com>
Date: Tue, 6 May 2025 21:54:50 +0200
From: Michael Riesch <michael.riesch@...labora.com>
To: Mehdi Djait <mehdi.djait@...ux.intel.com>
Cc: Maxime Chevallier <maxime.chevallier@...tlin.com>,
Théo Lebrun <theo.lebrun@...tlin.com>,
Gerald Loacker <gerald.loacker@...fvision.net>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring
<robh+dt@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
Kever Yang <kever.yang@...k-chips.com>,
Nicolas Dufresne <nicolas.dufresne@...labora.com>,
Sebastian Reichel <sebastian.reichel@...labora.com>,
Collabora Kernel Team <kernel@...labora.com>,
Paul Kocialkowski <paulk@...-base.io>,
Alexander Shiyan <eagle.alexander923@...il.com>,
Val Packett <val@...kett.cool>, Rob Herring <robh@...nel.org>,
Philipp Zabel <p.zabel@...gutronix.de>,
Sakari Ailus <sakari.ailus@...ux.intel.com>, linux-media@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
Michael Riesch <michael.riesch@...fvision.net>
Subject: Re: [PATCH v6 05/13] media: dt-bindings: add rockchip rk3568 mipi csi
receiver
Hi Mehdi,
On 5/6/25 14:09, Mehdi Djait wrote:
> Hi Michael,
>
> thank you for the patch!
>
> On Wed, Apr 30, 2025 at 11:15:54AM +0200, Michael Riesch via B4 Relay wrote:
>> From: Michael Riesch <michael.riesch@...fvision.net>
>>
>> Add documentation for the Rockchip RK3568 MIPI CSI-2 Receiver.
>>
>> Signed-off-by: Michael Riesch <michael.riesch@...fvision.net>
>> Signed-off-by: Michael Riesch <michael.riesch@...labora.com>
>> ---
>> .../bindings/media/rockchip,rk3568-mipi-csi.yaml | 113 +++++++++++++++++++++
>> MAINTAINERS | 1 +
>> 2 files changed, 114 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi.yaml
>> new file mode 100644
>> index 000000000000..d5004cb288dd
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi.yaml
>> @@ -0,0 +1,113 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/media/rockchip,rk3568-mipi-csi.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Rockchip RK3568 MIPI CSI-2 Receiver
>> +
>> +maintainers:
>> + - Michael Riesch <michael.riesch@...labora.com>
>> +
>> +description:
>> + The Rockchip RK3568 MIPI CSI-2 Receiver is a CSI-2 bridge with one input port
>> + and one output port. It receives the data with the help of an external
>> + MIPI PHY (C-PHY or D-PHY) and passes it to the Rockchip RK3568 Video Capture
>> + (VICAP) block.
>> +
>> +properties:
>> + compatible:
>> + const: rockchip,rk3568-mipi-csi
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + clocks:
>> + maxItems: 1
>> +
>> + phys:
>> + maxItems: 1
>> + description: MIPI C-PHY or D-PHY.
>> +
>> + power-domains:
>> + maxItems: 1
>> +
>> + resets:
>> + maxItems: 1
>> +
>> + ports:
>> + $ref: /schemas/graph.yaml#/properties/ports
>> +
>> + properties:
>> + port@0:
>> + $ref: /schemas/graph.yaml#/$defs/port-base
>> + unevaluatedProperties: false
>> + description: Input port node. Connect to e.g., a MIPI CSI-2 image sensor.
>> +
>> + properties:
>> + endpoint:
>> + $ref: video-interfaces.yaml#
>> + unevaluatedProperties: false
>> +
>> + properties:
>> + bus-type:
>> + enum: [1, 4]
>
> shouldn't you add data-lanes property here ?
Yes, makes sense.
Thanks for pointing it out -- will be in v7.
Best regards,
Michael
>
> data-lanes:
> minItems: 1
> maxItems: 4
>> +
>> + required:
>> + - bus-type
>
> and add it to required:
> - data-lanes
>
> you are actually checking for data-lanes when you enable the stream in:
>
> rkcif-mipi-csi-receiver.c +226
>
> u32 lanes = csi_dev->vep.bus.mipi_csi2.num_data_lanes;
>
> if (lanes < 1 || lanes > 4)
> return -EINVAL;
>
>> +
>> + port@1:
>> + $ref: /schemas/graph.yaml#/properties/port
>> + description: Output port connected to a RK3568 VICAP port.
>> +
>> + required:
>> + - port@0
>> + - port@1
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - clocks
>> + - phys
>> + - phy-names
>> + - ports
>> + - power-domains
>> + - resets
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/clock/rk3568-cru.h>
>> + #include <dt-bindings/power/rk3568-power.h>
>> +
>> + soc {
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> +
>> + csi: csi@...b0000 {
>> + compatible = "rockchip,rk3568-mipi-csi";
>> + reg = <0x0 0xfdfb0000 0x0 0x10000>;
>> + clocks = <&cru PCLK_CSI2HOST1>;
>> + phys = <&csi_dphy>;
>> + power-domains = <&power RK3568_PD_VI>;
>> + resets = <&cru SRST_P_CSI2HOST1>;
>> +
>> + ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + csi_in: port@0 {
>> + reg = <0>;
>> + };
>> +
>> + csi_out: port@1 {
>> + reg = <1>;
>> +
>> + csi_output: endpoint {
>> + remote-endpoint = <&vicap_mipi_input>;
>> + };
>> + };
>> + };
>> + };
>> + };
>
> --
> Kind Regards
> Mehdi Djait
Powered by blists - more mailing lists