linux-kernel - Re: [PATCH v3 sched_ext 2/2] sched_ext: Remove bpf_scx_get_func

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzbqrvgD11M5nTwP=oJeNph6n63qAZfW8Qu=MB9k3h_-ow@mail.gmail.com>
Date: Tue, 6 May 2025 15:30:39 -0700
From: Andrii Nakryiko <andrii.nakryiko@...il.com>
To: Feng Yang <yangfeng59949@....com>, tj@...nel.org
Cc: martin.lau@...ux.dev, ast@...nel.org, daniel@...earbox.net, 
	andrii@...nel.org, eddyz87@...il.com, song@...nel.org, 
	yonghong.song@...ux.dev, john.fastabend@...il.com, kpsingh@...nel.org, 
	sdf@...ichev.me, haoluo@...gle.com, jolsa@...nel.org, 
	mattbobrowski@...gle.com, rostedt@...dmis.org, mhiramat@...nel.org, 
	mathieu.desnoyers@...icios.com, davem@...emloft.net, bpf@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org, 
	netdev@...r.kernel.org
Subject: Re: [PATCH v3 sched_ext 2/2] sched_ext: Remove bpf_scx_get_func_proto

On Mon, May 5, 2025 at 11:15 PM Feng Yang <yangfeng59949@....com> wrote:
>
> From: Feng Yang <yangfeng@...inos.cn>
>
> task_storage_{get,delete} has been moved to bpf_base_func_proto.
>
> Suggested-by: Andrii Nakryiko <andrii.nakryiko@...il.com>
> Signed-off-by: Feng Yang <yangfeng@...inos.cn>
> ---
>  kernel/sched/ext.c | 15 +--------------
>  1 file changed, 1 insertion(+), 14 deletions(-)
>

Given this has dependency on patch #1, we should either route this
patch through bpf-next, or we'll have to delay and resend it after
merge window.

Tejun, any preferences?

> diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c
> index fdbf249d1c68..cc628b009e11 100644
> --- a/kernel/sched/ext.c
> +++ b/kernel/sched/ext.c
> @@ -5586,21 +5586,8 @@ static int bpf_scx_btf_struct_access(struct bpf_verifier_log *log,
>         return -EACCES;
>  }
>
> -static const struct bpf_func_proto *
> -bpf_scx_get_func_proto(enum bpf_func_id func_id, const struct bpf_prog *prog)
> -{
> -       switch (func_id) {
> -       case BPF_FUNC_task_storage_get:
> -               return &bpf_task_storage_get_proto;
> -       case BPF_FUNC_task_storage_delete:
> -               return &bpf_task_storage_delete_proto;
> -       default:
> -               return bpf_base_func_proto(func_id, prog);
> -       }
> -}
> -
>  static const struct bpf_verifier_ops bpf_scx_verifier_ops = {
> -       .get_func_proto = bpf_scx_get_func_proto,
> +       .get_func_proto = bpf_base_func_proto,
>         .is_valid_access = bpf_scx_is_valid_access,
>         .btf_struct_access = bpf_scx_btf_struct_access,
>  };
> --
> 2.43.0
>