linux-kernel - Re: [PATCH] irq-names dt-bindings: serial: Convert marvell,armada-3700-uart to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+T-NZE1--VN7J2c5GbpG8d4nWpfceKE=ZGg3wfXn5iFQ@mail.gmail.com>
Date: Tue, 6 May 2025 17:45:06 -0500
From: Rob Herring <robh@...nel.org>
To: Pali Rohár <pali@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby <jirislaby@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org, 
	linux-serial@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH] irq-names dt-bindings: serial: Convert
 marvell,armada-3700-uart to DT schema

On Tue, May 6, 2025 at 5:17 PM Pali Rohár <pali@...nel.org> wrote:
>
> On Tuesday 06 May 2025 17:00:41 Rob Herring (Arm) wrote:
> > Convert the Marvell Armada-3700 UART binding to DT schema. It is a
> > straight-forward conversion.
> >
> > Drop the long deprecated single interrupt support.
> >
> > Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> > ---
> >  .../serial/marvell,armada-3700-uart.yaml      | 102 ++++++++++++++++++
> >  .../devicetree/bindings/serial/mvebu-uart.txt |  56 ----------
> >  MAINTAINERS                                   |   2 +-
> >  3 files changed, 103 insertions(+), 57 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/serial/marvell,armada-3700-uart.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/serial/mvebu-uart.txt
> >
> > diff --git a/Documentation/devicetree/bindings/serial/marvell,armada-3700-uart.yaml b/Documentation/devicetree/bindings/serial/marvell,armada-3700-uart.yaml
> > new file mode 100644
> > index 000000000000..fa454337f06f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/serial/marvell,armada-3700-uart.yaml
> > @@ -0,0 +1,102 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/serial/marvell,armada-3700-uart.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Marvell Armada-3700 UART
> > +
> > +maintainers:
> > +  - Pali Rohár <pali@...nel.org>
> > +
> > +description:
> > +  Marvell UART is a non standard UART used in some of Marvell EBU SoCs (e.g.
> > +  Armada-3700).
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - marvell,armada-3700-uart
> > +      - marvell,armada-3700-uart-ext
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +    description:
> > +      UART reference clock used to derive the baud rate. If absent, only fixed
> > +      baud rate from the bootloader is supported.
> > +
> > +  interrupts:
> > +    minItems: 2
> > +    items:
> > +      - description: UART sum interrupt (deprecated single-element form)
> > +      - description: UART TX interrupt
> > +      - description: UART RX interrupt
>
> I think that this is wrong description and does not match the old txt
> description:

It's correct that a single irq entry is deprecated, but I did say I
dropped that. So "(deprecated single-element form)" should be dropped
here.

> - Must contain three elements for the standard variant of the IP
>   (marvell,armada-3700-uart): "uart-sum", "uart-tx" and "uart-rx",
>
> - Must contain two elements for the extended variant of the IP
>   (marvell,armada-3700-uart-ext): "uart-tx" and "uart-rx",

Note that the descriptions don't really match this either. Expressing
it correctly makes the schema worse (using a oneOf) and doesn't
improve validation. We have interrupt-names correct, so I think it is
fine.

Really, no one has cared for 6 years about this binding and converting
it, so I'm not going to spend a lot of time worrying about
descriptions. There's a 1000 more to do.

Rob