linux-kernel - Re: [PATCH] mm: vmscan: Avoid signedness error for GCC 5.4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250506162438.91fffc7ef924d9653ed0f503@linux-foundation.org>
Date: Tue, 6 May 2025 16:24:38 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: WangYuli <wangyuli@...ontech.com>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org, yuzhao@...gle.com,
 stevensd@...omium.org, kaleshsingh@...gle.com, zhanjun@...ontech.com,
 niecheng1@...ontech.com, guanwentao@...ontech.com
Subject: Re: [PATCH] mm: vmscan: Avoid signedness error for GCC 5.4

On Wed,  7 May 2025 00:02:38 +0800 WangYuli <wangyuli@...ontech.com> wrote:

> -	for (i = tier % MAX_NR_TIERS; i <= min(tier, MAX_NR_TIERS - 1); i++) {
> +	for (i = tier % MAX_NR_TIERS; i <= min(tier, (int)(MAX_NR_TIERS - 1)); i++) {
	
Make `tier' unsigned?  After all, negative tier numbers are nonsensical.