linux-kernel - Re: [PATCH v3] mm: Add CONFIG_PAGE_BLOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250506165013.4d48314b6d52d76148cb51f2@linux-foundation.org>
Date: Tue, 6 May 2025 16:50:13 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Vlastimil Babka <vbabka@...e.cz>
Cc: Juan Yescas <jyescas@...gle.com>, Zi Yan <ziy@...dia.com>,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org, tjmercier@...gle.com,
 isaacmanjarres@...gle.com, surenb@...gle.com, kaleshsingh@...gle.com,
 "Liam R. Howlett" <Liam.Howlett@...cle.com>, Lorenzo Stoakes
 <lorenzo.stoakes@...cle.com>, David Hildenbrand <david@...hat.com>, Mike
 Rapoport <rppt@...nel.org>, Minchan Kim <minchan@...nel.org>
Subject: Re: [PATCH v3] mm: Add CONFIG_PAGE_BLOCK_ORDER to select page block
 order

On Tue, 6 May 2025 14:48:19 +0200 Vlastimil Babka <vbabka@...e.cz> wrote:

> >> +config PAGE_BLOCK_ORDER
> >> +	int "Page Block Order"
> >> +	range 1 10 if !ARCH_FORCE_MAX_ORDER
> >> +	default 10 if !ARCH_FORCE_MAX_ORDER
> >> +	range 1 ARCH_FORCE_MAX_ORDER if ARCH_FORCE_MAX_ORDER
> >> +	default ARCH_FORCE_MAX_ORDER if ARCH_FORCE_MAX_ORDER
> > 
> > Do we really need to do this arithmetic within Kconfig?  Would it be
> > cleaner to do this at runtime, presumably when calculating
> > pageblock_order?
> 
> AFAIK pageblock_order is compile-time constant.

So it is.  Why the heck did we make it lower case?

And pageblock_nr_pages.