linux-kernel - Re: [PATCH net-next v7 03/11] net: ti: prueth: Adds PRUETH HW and SW configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <139244603.1233564.1746622561934.JavaMail.zimbra@couthit.local>
Date: Wed, 7 May 2025 18:26:01 +0530 (IST)
From: Parvathi Pudi <parvathi@...thit.com>
To: pabeni <pabeni@...hat.com>
Cc: danishanwar <danishanwar@...com>, rogerq <rogerq@...nel.org>, 
	andrew+netdev <andrew+netdev@...n.ch>, davem <davem@...emloft.net>, 
	edumazet <edumazet@...gle.com>, kuba <kuba@...nel.org>, 
	robh <robh@...nel.org>, krzk+dt <krzk+dt@...nel.org>, 
	conor+dt <conor+dt@...nel.org>, ssantosh <ssantosh@...nel.org>, 
	tony <tony@...mide.com>, richardcochran <richardcochran@...il.com>, 
	glaroque <glaroque@...libre.com>, schnelle <schnelle@...ux.ibm.com>, 
	m-karicheri2 <m-karicheri2@...com>, s hauer <s.hauer@...gutronix.de>, 
	rdunlap <rdunlap@...radead.org>, diogo ivo <diogo.ivo@...mens.com>, 
	basharath <basharath@...thit.com>, horms <horms@...nel.org>, 
	jacob e keller <jacob.e.keller@...el.com>, 
	m-malladi <m-malladi@...com>, 
	javier carrasco cruz <javier.carrasco.cruz@...il.com>, 
	afd <afd@...com>, s-anna <s-anna@...com>, 
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, 
	netdev <netdev@...r.kernel.org>, 
	devicetree <devicetree@...r.kernel.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>, 
	pratheesh <pratheesh@...com>, Prajith Jayarajan <prajith@...com>, 
	Vignesh Raghavendra <vigneshr@...com>, praneeth <praneeth@...com>, 
	srk <srk@...com>, rogerq <rogerq@...com>, 
	krishna <krishna@...thit.com>, pmohan <pmohan@...thit.com>, 
	parvathi <parvathi@...thit.com>, mohan <mohan@...thit.com>
Subject: Re: [PATCH net-next v7 03/11] net: ti: prueth: Adds PRUETH HW and
 SW configuration

Hi,

> On 5/3/25 2:10 PM, Parvathi Pudi wrote:
>> +static int icssm_prueth_emac_config(struct prueth_emac *emac)
>> +{
>> +	struct prueth *prueth = emac->prueth;
>> +
>> +	/* PRU needs local shared RAM address for C28 */
>> +	u32 sharedramaddr = ICSS_LOCAL_SHARED_RAM;
>> +
>> +	/* PRU needs real global OCMC address for C30*/
>> +	u32 ocmcaddr = (u32)prueth->mem[PRUETH_MEM_OCMC].pa;
>> +	void __iomem *dram_base;
>> +	void __iomem *mac_addr;
>> +	void __iomem *dram;
> 
> Minor nit: please respect the reverse christmas tree order above.
> 
> /P

We will address this in the next version.


Thanks and Regards,
Parvathi.