linux-kernel - Re: [PATCH v2 5/5] Documentation: admin-guide: pm: Add documentation for die

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b93214c-458c-c062-7a7b-45750f368c35@linux.intel.com>
Date: Wed, 7 May 2025 16:09:09 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
cc: Hans de Goede <hdegoede@...hat.com>, platform-driver-x86@...r.kernel.org, 
    LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 5/5] Documentation: admin-guide: pm: Add documentation
 for die_id

On Mon, 28 Apr 2025, Srinivas Pandruvada wrote:

> Add documentation to describe die_id attribute.
> 
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> ---
> v2:
> Change "attributes" to "attribute"
> 
>  .../admin-guide/pm/intel_uncore_frequency_scaling.rst        | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/admin-guide/pm/intel_uncore_frequency_scaling.rst b/Documentation/admin-guide/pm/intel_uncore_frequency_scaling.rst
> index 84608dad84bd..d7ffda6a8095 100644
> --- a/Documentation/admin-guide/pm/intel_uncore_frequency_scaling.rst
> +++ b/Documentation/admin-guide/pm/intel_uncore_frequency_scaling.rst
> @@ -91,6 +91,11 @@ Attributes in each directory:
>  ``domain_id``
>  	This attribute is used to get the power domain id of this instance.
>  
> +``die_id``
> +	This attribute is used to get the Linux die id of this instance.
> +	This attribute is only present for domains with core agents and
> +        when the CPUID leaf 0x1f presents die ID.
> +
>  ``fabric_cluster_id``
>  	This attribute is used to get the fabric cluster id of this instance.
>  
> 

For patches #2-#5,

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

It would have been nice to use cleanup.h in #3 but there's no good 
alternative for no_free_ptr() that doesn't have __must_check (IIRC, 
somebody proposed a solution to this relatively recently but I don't see 
that in linux/cleanup.h currently so lets forget that for now).

-- 
 i.