linux-kernel - Re: [PATCH] ACPI: APEI: EINJ: Fix probe error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hcN9B7TukPcE+xAzDEgt66BbnN+SUmuFaWU0ddKjdM4w@mail.gmail.com>
Date: Wed, 7 May 2025 15:24:46 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Sudeep Holla <sudeep.holla@....com>, Jon Hunter <jonathanh@...dia.com>
Cc: linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-tegra@...r.kernel.org
Subject: Re: [PATCH] ACPI: APEI: EINJ: Fix probe error message

On Thu, May 1, 2025 at 2:53 PM Sudeep Holla <sudeep.holla@....com> wrote:
>
> On Thu, May 01, 2025 at 01:46:21PM +0100, Jon Hunter wrote:
> > Commit 6cb9441bfe8d ("ACPI: APEI: EINJ: Transition to the faux device
> > interface") updated the APEI error injection driver to use the faux
> > device interface and now for devices that don't support ACPI, the
> > following error message is seen on boot:
> >
> >  ERR KERN faux acpi-einj: probe did not succeed, tearing down the device
> >
> > The APEI error injection driver returns -ENODEV in the probe function
> > if ACPI is not supported and so after transitioning the driver to the
> > faux device interface, the error returned from the probe now causes the
> > above error message to be displayed.
> >
> > Fix this by moving the code that detects if ACPI is supported to the
> > einj_init() function to fix the false error message displayed for
> > devices that don't support ACPI.
> >
>
> Good catch, it was silently passing error before.
>
> Reviewed-by: Sudeep Holla <sudeep.holla@....com>

Applied, thanks!

That said, when fixing a bug that is only present in linux-next and
not yet in the mainline, I'd appreciate a note about this, especially
if it carries a Fixes: tag, because I do rebase patches occasionally
and the commit ids may get stale.