linux-kernel - Re: [PATCH] arm64: Kconfig.platforms: remove useless select for ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1949ec7-a0b3-4c4c-a439-93afced7bb0c@baylibre.com>
Date: Wed, 7 May 2025 15:28:26 +0200
From: Guillaume La Roque <glaroque@...libre.com>
To: Nishanth Menon <nm@...com>
Cc: Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Andrew Davis <afd@...com>, vishalm@...com, linux-omap@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: Kconfig.platforms: remove useless select for
 ARCH_K3

Hi Nishanth,

if i remove MAILBOX it's  enabled by some  non TI drivers and/or 
ARCH_XXX which have it in deps so all TI drivers are still enabled 
properly but not sure it's safe.
and PM_GENERIC_DOMAINS look OK to remove it.

if i try a defconfig based on android defconfig (more simple than 
default defconfig) with only ARCH_K3 enabled i need to set 
CONFIG_MAILBOX flag to still have same TI drivers enabled.
let me know what you want to do.

Guillaume
Le 05/05/2025 à 15:15, Guillaume La Roque a écrit :
> Hi,
>
> Le 05/05/2025 à 14:36, Nishanth Menon a écrit :
>> On 13:24-20250504, Guillaume La Roque wrote:
>>> After patch done on TI_MESSAGE_MANAGER[1] and TI_SCI_PROTOCOL[2] driver
>>> select on ARCH_K3 are not needed anymore.
>>>
>>> Remove it and give possibility to enable this driver in modules.
>>>
>>> [1] https://lore.kernel.org/all/20180828005311.8529-1-nm@ti.com/
>>> [2] 
>>> https://lore.kernel.org/all/20250220-ti-firmware-v2-1-ff26883c6ce9@baylibre.com/
>>>
>>> Signed-off-by: Guillaume La Roque <glaroque@...libre.com>
>>> ---
>>>   arch/arm64/Kconfig.platforms | 2 --
>>>   1 file changed, 2 deletions(-)
>>>
>>> diff --git a/arch/arm64/Kconfig.platforms 
>>> b/arch/arm64/Kconfig.platforms
>>> index 8b76821f190f..5b63a42c4dff 100644
>>> --- a/arch/arm64/Kconfig.platforms
>>> +++ b/arch/arm64/Kconfig.platforms
>>> @@ -138,8 +138,6 @@ config ARCH_K3
>>>       select PM_GENERIC_DOMAINS if PM
>>>       select MAILBOX
>>>       select SOC_TI
>>> -    select TI_MESSAGE_MANAGER
>>> -    select TI_SCI_PROTOCOL
>>>       select TI_K3_SOCINFO
>>>       help
>>>         This enables support for Texas Instruments' K3 multicore SoC
>>>
>> While at this, is it possible to remove MAILBOX and PM_GENERIC_DOMAINS
>> from select and make them as modules?
>>
> good point i will confirm  and come back to you.