linux-kernel - Re: [RFC PATCH 12/15] loongarch/perf: Remove driver-specific throttle support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4b5212a8-f6e2-4a75-b768-bef0d17ab332@linux.intel.com>
Date: Wed, 7 May 2025 09:45:39 -0400
From: "Liang, Kan" <kan.liang@...ux.intel.com>
To: 陈华才 <chenhuacai@...ngson.cn>
Cc: peterz@...radead.org, mingo@...hat.com, namhyung@...nel.org,
 irogers@...gle.com, mark.rutland@....com, linux-kernel@...r.kernel.org,
 linux-perf-users@...r.kernel.org, eranian@...gle.com, ctshao@...gle.com,
 tmricht@...ux.ibm.com, Bibo Mao <maobibo@...ngson.cn>,
 loongarch@...ts.linux.dev
Subject: Re: [RFC PATCH 12/15] loongarch/perf: Remove driver-specific throttle
 support



On 2025-05-06 9:17 p.m., 陈华才 wrote:
> Hi, Liang,
> 
> Since which version we need this patch? I mean which versions this patch should be backported.

The generic change hasn't been merged. It's still under review.
https://lore.kernel.org/lkml/20250506164740.1317237-2-kan.liang@linux.intel.com/

The driver-specific change should be applied after the generic change is
merged.

> And you need to CC loongarch@...ts.linux.dev.
> 

Sure.

Thanks,
Kan

> Huacai
> 
> 
>> -----原始邮件-----
>> 发件人: kan.liang@...ux.intel.com
>> 发送时间:2025-05-07 00:47:37 (星期三)
>> 收件人: peterz@...radead.org, mingo@...hat.com, namhyung@...nel.org, irogers@...gle.com, mark.rutland@....com, linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org
>> 抄送: eranian@...gle.com, ctshao@...gle.com, tmricht@...ux.ibm.com, "Kan Liang" <kan.liang@...ux.intel.com>, "Bibo Mao" <maobibo@...ngson.cn>, "Huacai Chen" <chenhuacai@...ngson.cn>
>> 主题: [RFC PATCH 12/15] loongarch/perf: Remove driver-specific throttle support
>>
>> From: Kan Liang <kan.liang@...ux.intel.com>
>>
>> The throttle support has been added in the generic code. Remove
>> the driver-specific throttle support.
>>
>> Besides the throttle, perf_event_overflow may return true because of
>> event_limit. It already does an inatomic event disable. The pmu->stop
>> is not required either.
>>
>> Signed-off-by: Kan Liang <kan.liang@...ux.intel.com>
>> Cc: Bibo Mao <maobibo@...ngson.cn>
>> Cc: Huacai Chen <chenhuacai@...ngson.cn>
>> ---
>>  arch/loongarch/kernel/perf_event.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/loongarch/kernel/perf_event.c b/arch/loongarch/kernel/perf_event.c
>> index f86a4b838dd7..8ad098703488 100644
>> --- a/arch/loongarch/kernel/perf_event.c
>> +++ b/arch/loongarch/kernel/perf_event.c
>> @@ -479,8 +479,7 @@ static void handle_associated_event(struct cpu_hw_events *cpuc, int idx,
>>  	if (!loongarch_pmu_event_set_period(event, hwc, idx))
>>  		return;
>>  
>> -	if (perf_event_overflow(event, data, regs))
>> -		loongarch_pmu_disable_event(idx);
>> +	perf_event_overflow(event, data, regs);
>>  }
>>  
>>  static irqreturn_t pmu_handle_irq(int irq, void *dev)
>> -- 
>> 2.38.1
> 
> 
> 本邮件及其附件含有龙芯中科的商业秘密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制或散发）本邮件及其附件中的信息。如果您错收本邮件，请您立即电话或邮件通知发件人并删除本邮件。 
> This email and its attachments contain confidential information from Loongson Technology , which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this email in error, please notify the sender by phone or email immediately and delete it. 
> 
>