linux-kernel - Re: [FIRST-PATCH] staging : sm750fb : ddk750

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025050737-lunchtime-quake-6128@gregkh>
Date: Wed, 7 May 2025 16:37:06 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Rujra Bhatt <braker.noob.kernel@...il.com>
Cc: sudipm.mukherjee@...il.com, teddy.wang@...iconmotion.com,
	linux-fbdev@...r.kernel.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [FIRST-PATCH] staging : sm750fb : ddk750_mode.c fixed codespell
 issue.

On Wed, May 07, 2025 at 08:01:26PM +0530, Rujra Bhatt wrote:
> instead of "parm" structure variable, used "param" to ease the readability.
> 
> Signed-off-by: Rujra Bhatt <braker.noob.kernel@...il.com>
> ---
>  drivers/staging/sm750fb/ddk750_mode.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
> index 3b25892af713..8f2708632c88 100644
> --- a/drivers/staging/sm750fb/ddk750_mode.c
> +++ b/drivers/staging/sm750fb/ddk750_mode.c
> @@ -203,19 +203,19 @@ static void program_mode_registers(struct mode_parameter *mode_param,
>  	}
>  }
>  
> -int ddk750_set_mode_timing(struct mode_parameter *parm, enum clock_type clock)
> +int ddk750_set_mode_timing(struct mode_parameter *param, enum clock_type clock)
>  {
>  	struct pll_value pll;
>  
>  	pll.input_freq = DEFAULT_INPUT_CLOCK;
>  	pll.clock_type = clock;
>  
> -	sm750_calc_pll_value(parm->pixel_clock, &pll);
> +	sm750_calc_pll_value(param->pixel_clock, &pll);
>  	if (sm750_get_chip_type() == SM750LE) {
>  		/* set graphic mode via IO method */
>  		outb_p(0x88, 0x3d4);
>  		outb_p(0x06, 0x3d5);
>  	}
> -	program_mode_registers(parm, &pll);
> +	program_mode_registers(param, &pll);

This change is really not needed at all, sorry.  Adding one character
doesn't make it easier to understand in my opinion.

thanks,

greg k-h