linux-kernel - Re: [PATCH] dt-bindings: serial: Convert socionext,milbeaut-usio-uart to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqL9tN_9r8nNXFK0u=pn0z+vL6jbNttHiy0kUTLniAPXzQ@mail.gmail.com>
Date: Wed, 7 May 2025 09:47:25 -0500
From: Rob Herring <robh@...nel.org>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby <jirislaby@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Taichi Sugaya <sugaya.taichi@...ionext.com>, Takao Orito <orito.takao@...ionext.com>
Cc: linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] dt-bindings: serial: Convert socionext,milbeaut-usio-uart
 to DT schema

On Tue, May 6, 2025 at 5:00 PM Rob Herring (Arm) <robh@...nel.org> wrote:
>
> Convert the Socionext Milbeaut UART binding to DT schema. It is a
> straight-forward conversion.
>
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---
>  .../bindings/serial/milbeaut-uart.txt         | 21 -------
>  .../serial/socionext,milbeaut-usio-uart.yaml  | 56 +++++++++++++++++++
>  2 files changed, 56 insertions(+), 21 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/serial/milbeaut-uart.txt
>  create mode 100644 Documentation/devicetree/bindings/serial/socionext,milbeaut-usio-uart.yaml
>
> diff --git a/Documentation/devicetree/bindings/serial/milbeaut-uart.txt b/Documentation/devicetree/bindings/serial/milbeaut-uart.txt
> deleted file mode 100644
> index 3d2fb1a7ba94..000000000000
> --- a/Documentation/devicetree/bindings/serial/milbeaut-uart.txt
> +++ /dev/null
> @@ -1,21 +0,0 @@
> -Socionext Milbeaut UART controller
> -
> -Required properties:
> -- compatible: should be "socionext,milbeaut-usio-uart".
> -- reg: offset and length of the register set for the device.
> -- interrupts: two interrupts specifier.
> -- interrupt-names: should be "rx", "tx".
> -- clocks: phandle to the input clock.
> -
> -Optional properties:
> -- auto-flow-control: flow control enable.
> -
> -Example:
> -       usio1: usio_uart@...00010 {
> -               compatible = "socionext,milbeaut-usio-uart";
> -               reg = <0x1e700010 0x10>;
> -               interrupts = <0 141 0x4>, <0 149 0x4>;
> -               interrupt-names = "rx", "tx";
> -               clocks = <&clk 2>;
> -               auto-flow-control;
> -       };
> diff --git a/Documentation/devicetree/bindings/serial/socionext,milbeaut-usio-uart.yaml b/Documentation/devicetree/bindings/serial/socionext,milbeaut-usio-uart.yaml
> new file mode 100644
> index 000000000000..37db6459b67a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/serial/socionext,milbeaut-usio-uart.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/socionext,milbeaut-usio-uart.yaml#

This is missing 'serial' in the path, so a v2 is coming.

The tooling didn't catch this as it doesn't know what the root
directory (bindings) is until a reference is used and the reference
checking happened to miss this case. I've now fixed that.

Rob