linux-kernel - Re: [PATCH 1/4] fs/netfs: convert `netfs_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKPOu+-y6vng-hc7HN=+0U0cuEZCWm-BuYC3GOGGTwJHrJMDjw@mail.gmail.com>
Date: Wed, 7 May 2025 17:48:24 +0200
From: Max Kellermann <max.kellermann@...os.com>
To: dhowells@...hat.com, netfs@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] fs/netfs: convert `netfs_io_request.error` to a `short

On Wed, May 7, 2025 at 11:01 AM kernel test robot <lkp@...el.com> wrote:

> All errors (new ones prefixed by >>, old ones prefixed by <<):
>
> >> ERROR: modpost: "__cmpxchg_called_with_bad_pointer" [fs/netfs/netfs.ko] undefined!

Okay, not all architectures support cmpxchg() with a short. I can drop
this patch, but I'm curious why netfs_read_to_pagecache() uses
cmpxchg() when everybody else simply assigns the value. Maybe, if
cmpxchg() turns out to be unnecessary, we can keep this patch? David,
can you explain? You added it in commit ee4cdf7ba857a ("netfs: Speed
up buffered reading").

Max