linux-kernel - Re: [PATCH] spi: tegra114: Use value to check for invalid delays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2015e3f3-cab4-447c-93ac-23d9af14977b@nvidia.com>
Date: Wed, 7 May 2025 16:51:51 +0100
From: Jon Hunter <jonathanh@...dia.com>
To: webgeek1234@...il.com, Laxman Dewangan <ldewangan@...dia.com>,
 Mark Brown <broonie@...nel.org>, Thierry Reding <thierry.reding@...il.com>
Cc: linux-spi@...r.kernel.org, linux-tegra@...r.kernel.org,
 linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] spi: tegra114: Use value to check for invalid delays


On 06/05/2025 19:36, Aaron Kling via B4 Relay wrote:
> From: Aaron Kling <webgeek1234@...il.com>
> 
> A delay unit of 0 is a valid entry, thus it is not valid to check for
> unused delays. Instead, check the value field; if that is zero, the
> given delay is unset.
> 
> Fixes: 4426e6b4ecf6 ("spi: tegra114: Don't fail set_cs_timing when delays are zero")
> Cc: stable@...r.kernel.org
> Signed-off-by: Aaron Kling <webgeek1234@...il.com>
> ---
>   drivers/spi/spi-tegra114.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c
> index 2a8bb798e95b954fe573f1c50445ed2e7fcbfd78..795a8482c2c700c3768bd50bf59971256893a486 100644
> --- a/drivers/spi/spi-tegra114.c
> +++ b/drivers/spi/spi-tegra114.c
> @@ -728,9 +728,9 @@ static int tegra_spi_set_hw_cs_timing(struct spi_device *spi)
>   	u32 inactive_cycles;
>   	u8 cs_state;
>   
> -	if ((setup->unit && setup->unit != SPI_DELAY_UNIT_SCK) ||
> -	    (hold->unit && hold->unit != SPI_DELAY_UNIT_SCK) ||
> -	    (inactive->unit && inactive->unit != SPI_DELAY_UNIT_SCK)) {
> +	if ((setup->value && setup->unit != SPI_DELAY_UNIT_SCK) ||
> +	    (hold->value && hold->unit != SPI_DELAY_UNIT_SCK) ||
> +	    (inactive->value && inactive->unit != SPI_DELAY_UNIT_SCK)) {
>   		dev_err(&spi->dev,
>   			"Invalid delay unit %d, should be SPI_DELAY_UNIT_SCK\n",
>   			SPI_DELAY_UNIT_SCK);
> 
> ---
> base-commit: 0d8d44db295ccad20052d6301ef49ff01fb8ae2d
> change-id: 20250506-spi-tegra114-fixup-dbf6730db087


That looks better to me.

Reviewed-by: Jon Hunter <jonathanh@...dia.com>

Thanks
Jon

-- 
nvpublic