linux-kernel - Re: [PATCH net-next v8 2/7] net: usb: lan78xx: remove explicit check for missing PHY driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33ddfd32a5566f4990ded4334282df723e88a77b.camel@microchip.com>
Date: Wed, 7 May 2025 03:57:54 +0000
From: <Thangaraj.S@...rochip.com>
To: <andrew+netdev@...n.ch>, <rmk+kernel@...linux.org.uk>,
	<davem@...emloft.net>, <Rengarajan.S@...rochip.com>,
	<Woojung.Huh@...rochip.com>, <pabeni@...hat.com>, <o.rempel@...gutronix.de>,
	<edumazet@...gle.com>, <kuba@...nel.org>
CC: <phil@...pberrypi.org>, <kernel@...gutronix.de>, <horms@...nel.org>,
	<linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
	<UNGLinuxDriver@...rochip.com>, <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH net-next v8 2/7] net: usb: lan78xx: remove explicit check
 for missing PHY driver

On Mon, 2025-05-05 at 10:43 +0200, Oleksij Rempel wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> RGMII timing correctness relies on the PHY providing internal delays.
> This is typically ensured via PHY driver, strap pins, or PCB layout.
> 
> Explicitly checking for a PHY driver here is unnecessary and non-
> standard.
> This logic applies to all MACs, not just LAN78xx, and should be left
> to
> phylib, phylink, or platform configuration.
> 
> Drop the check and rely on standard subsystem behavior.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> 
Reviewed-by: Thangaraj Samynathan <thangaraj.s@...rochip.com>