linux-kernel - Re: [RFC PATCH 2/6] x86/x2apic-savic: Expose x2apic_savic_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMvTesDWCbg8=YOpc_8CQW_ufhat2uQ1J+Ar-HoB39Sa29A9PA@mail.gmail.com>
Date: Thu, 8 May 2025 00:15:57 +0800
From: Tianyu Lan <ltykernel@...il.com>
To: Neeraj Upadhyay <Neeraj.Upadhyay@....com>
Cc: kys@...rosoft.com, haiyangz@...rosoft.com, wei.liu@...nel.org, 
	decui@...rosoft.com, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, 
	dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com, 
	yuehaibing@...wei.com, kvijayab@....com, jacob.jun.pan@...ux.intel.com, 
	jpoimboe@...nel.org, tiala@...rosoft.com, linux-hyperv@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 2/6] x86/x2apic-savic: Expose x2apic_savic_update_vector()

On Wed, May 7, 2025 at 11:57 AM Neeraj Upadhyay <Neeraj.Upadhyay@....com> wrote:
>
>
>
> On 5/6/2025 6:37 PM, Tianyu Lan wrote:
> > From: Tianyu Lan <tiala@...rosoft.com>
> >
> > Expose x2apic_savic_update_vector() and device driver
> > arch code may update AVIC backing page to allow Hyper-V
> > inject associated vector.
> >
> > Signed-off-by: Tianyu Lan <tiala@...rosoft.com>
>
> I think this new interface is not required. Device driver arch code can call
> apic_update_vector() to invoke APIC driver's update_vector() callback.
> Or is it that I am missing something? So, can you explain why this new interface
> is needed?

Hi Neeraj:
       Thank you for your review. Agree. apic_update_vector() should be enough.
Will update.

Thanks.