linux-kernel - Re: [RFC][PATCH 04/14] soc: qcom: smem: add minidump device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <voqxvemo6w7zmoo45yb7wlei6gz4wd4m7vdgvclptzx7y7avht@4x77c3frno32>
Date: Wed, 7 May 2025 09:56:22 -0700
From: Bjorn Andersson <andersson@...nel.org>
To: Eugen Hristev <eugen.hristev@...aro.org>
Cc: linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org, 
	linux-doc@...r.kernel.org, corbet@....net, tglx@...utronix.de, mingo@...hat.com, 
	rostedt@...dmis.org, john.ogness@...utronix.de, senozhatsky@...omium.org, 
	pmladek@...e.com, peterz@...radead.org, mojha@....qualcomm.com, 
	linux-arm-kernel@...ts.infradead.org, vincent.guittot@...aro.org, konradybcio@...nel.org, 
	dietmar.eggemann@....com, juri.lelli@...hat.com
Subject: Re: [RFC][PATCH 04/14] soc: qcom: smem: add minidump device

On Tue, Apr 22, 2025 at 02:31:46PM +0300, Eugen Hristev wrote:
> Add a minidump platform device.

Please provide a bit more context here.

> 
> Signed-off-by: Eugen Hristev <eugen.hristev@...aro.org>
> ---
>  drivers/soc/qcom/smem.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
> index 592819701809..985147b563f8 100644
> --- a/drivers/soc/qcom/smem.c
> +++ b/drivers/soc/qcom/smem.c
> @@ -270,6 +270,7 @@ struct smem_region {
>   * @partitions: list of partitions of current processor/host
>   * @item_count: max accepted item number
>   * @socinfo:	platform device pointer
> + * @mdinfo:	minidump device pointer
>   * @num_regions: number of @regions
>   * @regions:	list of the memory regions defining the shared memory
>   */
> @@ -280,6 +281,7 @@ struct qcom_smem {
>  
>  	u32 item_count;
>  	struct platform_device *socinfo;
> +	struct platform_device *mdinfo;
>  	struct smem_ptable *ptable;
>  	struct smem_partition global_partition;
>  	struct smem_partition partitions[SMEM_HOST_COUNT];
> @@ -1236,12 +1238,20 @@ static int qcom_smem_probe(struct platform_device *pdev)
>  	if (IS_ERR(smem->socinfo))
>  		dev_dbg(&pdev->dev, "failed to register socinfo device\n");
>  
> +	smem->mdinfo = platform_device_register_data(&pdev->dev, "qcom-md",

Let's spell out "minidump" here.

Regards,
Bjorn

> +						     PLATFORM_DEVID_AUTO, NULL,
> +						     0);
> +	if (IS_ERR(smem->mdinfo))
> +		dev_err(&pdev->dev, "failed to register platform md device\n");
> +
>  	return 0;
>  }
>  
>  static void qcom_smem_remove(struct platform_device *pdev)
>  {
>  	platform_device_unregister(__smem->socinfo);
> +	if (!IS_ERR(__smem->mdinfo))
> +		platform_device_unregister(__smem->mdinfo);
>  
>  	hwspin_lock_free(__smem->hwlock);
>  	__smem = NULL;
> -- 
> 2.43.0
>