linux-kernel - Re: [PATCH][next] ASoC: rt712-sdca: remove redundant else path of if statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ab1af21-ebe4-43a4-bb70-fa25c442e24f@wanadoo.fr>
Date: Wed, 7 May 2025 19:15:18 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Colin Ian King <colin.i.king@...il.com>,
 Oder Chiou <oder_chiou@...ltek.com>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
 linux-sound@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] ASoC: rt712-sdca: remove redundant else path of if
 statement

Le 07/05/2025 à 16:09, Colin Ian King a écrit :
> There is an if/else check where the else part is executed if
> adc_vol_flag is true, this else path checks if adc_vol_flag
> is true (which is a redundant second check) and the if path is
> always taken. Remove the redundant check and remove the else
> path since that can never occur.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>   sound/soc/codecs/rt712-sdca.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/sound/soc/codecs/rt712-sdca.c b/sound/soc/codecs/rt712-sdca.c
> index 19d99b9d4ab2..570c2af1245d 100644
> --- a/sound/soc/codecs/rt712-sdca.c
> +++ b/sound/soc/codecs/rt712-sdca.c
> @@ -1065,12 +1065,8 @@ static int rt712_sdca_dmic_set_gain_get(struct snd_kcontrol *kcontrol,
>   
>   		if (!adc_vol_flag) /* boost gain */
>   			ctl = regvalue / 0x0a00;
> -		else { /* ADC gain */
> -			if (adc_vol_flag)
> -				ctl = p->max - (((0x1e00 - regvalue) & 0xffff) / interval_offset);
> -			else
> -				ctl = p->max - (((0 - regvalue) & 0xffff) / interval_offset);
> -		}
> +		else /* ADC gain */
> +			ctl = p->max - (((0x1e00 - regvalue) & 0xffff) / interval_offset);
>   
>   		ucontrol->value.integer.value[i] = ctl;
>   	}

Hi,

apparently the same pattern is in rt712-sdca-dmic.c.

CJ