| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <f806853a-199e-4a04-8bae-a9697e9a5cca@phytec.de>
Date: Wed, 7 May 2025 06:38:04 +0200
From: Daniel Schultz <d.schultz@...tec.de>
To: Wadim Egorov <w.egorov@...tec.de>, nm@...com, vigneshr@...com,
kristo@...nel.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, Andrew Davis <afd@...com>
Cc: upstream@...ts.phytec.de
Subject: Re: [PATCH v2 2/4] arm64: dts: ti: k3-am62a-phycore-som: Enable
Co-processors
On 5/6/25 17:41, Wadim Egorov wrote:
> Am 06.05.25 um 16:36 schrieb Daniel Schultz:
>> For every remote processor, set up dedicated memory regions and
>> associate the required mailbox channels. Allocate two memory areas
>> per remote core: one 1MB region for vring shared buffers, and
>> another for external memory used by the remote processor for its
>> resource table and trace buffer.
>>
>> Signed-off-by: Daniel Schultz <d.schultz@...tec.de>
>> ---
>> .../boot/dts/ti/k3-am62a-phycore-som.dtsi | 96 +++++++++++++++++--
>> 1 file changed, 90 insertions(+), 6 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am62a-phycore-som.dtsi
>> b/arch/arm64/boot/dts/ti/k3-am62a-phycore-som.dtsi
>> index 147d56b87984..049aa358e796 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am62a-phycore-som.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am62a-phycore-som.dtsi
>> @@ -59,6 +59,42 @@ linux,cma {
>> linux,cma-default;
>> };
>> + c7x_0_dma_memory_region: c7x-dma-memory@...00000 {
>> + compatible = "shared-dma-pool";
>> + reg = <0x00 0x99800000 0x00 0x100000>;
>> + no-map;
>> + };
>> +
>> + c7x_0_memory_region: c7x-memory@...00000 {
>> + compatible = "shared-dma-pool";
>> + reg = <0x00 0x99900000 0x00 0xf00000>;
>
> Just checked the origin of this for the am62a7-sk, which is
> https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/?h=10.01.10&id=a82cef91b301e3a03a4efe0f49e6cb8cf50f43af
>
> The size for the c7x-memory is 0x01f00000 and not 0xf00000
>
>> + no-map;
>> + };
>> +
>> + mcu_r5fss0_core0_dma_memory_region: r5f-dma-memory@...00000 {
>
> which is relevant because your next reserved memory area starts at
> 0x9b800000 (would be fine with a size of 0x1f00000). If you really
> want to have a size of 0xf00000, your next block should start at
> 9A800000.
>
> Can you please double check and use the free memory inbetween if
> 0xf00000 is correct.
Hi Wadim,
I copied all those nodes from the k3-am62a7-sk board update which just
got merged [1]. I don't want to change that now because I'm afraid the
default TI mcu firmware won't work with different addresses anymore.
@Andrew: FYI there is a gap now in reserved memory but I assume you're
already aware.
- Daniel
1:
https://lore.kernel.org/linux-arm-kernel/174653697389.718892.12387672790395559537.b4-ty@ti.com/T/#m7f099b9507759c8f56733004222ed1b1bbdd0736
>
>> + compatible = "shared-dma-pool";
>> + reg = <0x00 0x9b800000 0x00 0x100000>;
>> + no-map;
>> + };
>> +
>> + mcu_r5fss0_core0_memory_region: r5f-dma-memory@...00000 {
>> + compatible = "shared-dma-pool";
>> + reg = <0x00 0x9b900000 0x00 0xf00000>;
>> + no-map;
>> + };
>> +
>> + wkup_r5fss0_core0_dma_memory_region: r5f-dma-memory@...00000 {
>> + compatible = "shared-dma-pool";
>> + reg = <0x00 0x9c800000 0x00 0x100000>;
>> + no-map;
>> + };
>> +
>> + wkup_r5fss0_core0_memory_region: r5f-dma-memory@...00000 {
>> + compatible = "shared-dma-pool";
>> + reg = <0x00 0x9c900000 0x00 0xf00000>;
>> + no-map;
>> + };
>> +
>> secure_tfa_ddr: tfa@...80000 {
>> reg = <0x00 0x9e780000 0x00 0x80000>;
>> alignment = <0x1000>;
>> @@ -70,12 +106,6 @@ secure_ddr: optee@...00000 {
>> alignment = <0x1000>;
>> no-map;
>> };
>> -
>> - wkup_r5fss0_core0_memory_region: r5f-dma-memory@...00000 {
>> - compatible = "shared-dma-pool";
>> - reg = <0x00 0x9c900000 0x00 0x01e00000>;
>> - no-map;
>> - };
>> };
>> vcc_5v0_som: regulator-vcc-5v0-som {
>> @@ -170,6 +200,13 @@ AM62AX_IOPAD(0x1f4, PIN_INPUT, 0) /* (D16)
>> EXTINTn */
>> };
>> };
>> +&c7x_0 {
>> + mboxes = <&mailbox0_cluster1>, <&mbox_c7x_0>;
>> + memory-region = <&c7x_0_dma_memory_region>,
>> + <&c7x_0_memory_region>;
>> + status = "okay";
>> +};
>> +
>> &cpsw3g {
>> pinctrl-names = "default";
>> pinctrl-0 = <&main_rgmii1_pins_default>;
>> @@ -200,6 +237,33 @@ &fss {
>> status = "okay";
>> };
>> +&mailbox0_cluster0 {
>> + status = "okay";
>> +
>> + mbox_r5_0: mbox-r5-0 {
>> + ti,mbox-rx = <0 0 0>;
>> + ti,mbox-tx = <1 0 0>;
>> + };
>> +};
>> +
>> +&mailbox0_cluster1 {
>> + status = "okay";
>> +
>> + mbox_c7x_0: mbox-c7x-0 {
>> + ti,mbox-rx = <0 0 0>;
>> + ti,mbox-tx = <1 0 0>;
>> + };
>> +};
>> +
>> +&mailbox0_cluster2 {
>> + status = "okay";
>> +
>> + mbox_mcu_r5_0: mbox-mcu-r5-0 {
>> + ti,mbox-rx = <0 0 0>;
>> + ti,mbox-tx = <1 0 0>;
>> + };
>> +};
>> +
>> &main_i2c0 {
>> pinctrl-names = "default";
>> pinctrl-0 = <&main_i2c0_pins_default>;
>> @@ -315,6 +379,16 @@ &main_pktdma {
>> bootph-all;
>> };
>> +&mcu_r5fss0 {
>> + status = "okay";
>> +};
>> +
>> +&mcu_r5fss0_core0 {
>> + mboxes = <&mailbox0_cluster2>, <&mbox_mcu_r5_0>;
>> + memory-region = <&mcu_r5fss0_core0_dma_memory_region>,
>> + <&mcu_r5fss0_core0_memory_region>;
>> +};
>> +
>> &ospi0 {
>> pinctrl-names = "default";
>> pinctrl-0 = <&ospi0_pins_default>;
>> @@ -343,3 +417,13 @@ &sdhci0 {
>> bootph-all;
>> status = "okay";
>> };
>> +
>> +&wkup_r5fss0 {
>> + status = "okay";
>> +};
>> +
>> +&wkup_r5fss0_core0 {
>> + mboxes = <&mailbox0_cluster0>, <&mbox_r5_0>;
>> + memory-region = <&wkup_r5fss0_core0_dma_memory_region>,
>> + <&wkup_r5fss0_core0_memory_region>;
>> +};
>
Powered by blists - more mailing lists