linux-kernel - Re: [PATCH v2] selftests/ftrace: Convert poll to a gen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250507152653.4af2549a@gandalf.local.home>
Date: Wed, 7 May 2025 15:26:53 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Ayush Jain <Ayush.jain3@....com>
Cc: <mhiramat@...nel.org>, <mathieu.desnoyers@...icios.com>,
 <linux-kernel@...r.kernel.org>, <linux-trace-kernel@...r.kernel.org>,
 <linux-kselftest@...r.kernel.org>, <Naveen.Rao@....com>,
 <Kalpana.Shetty@....com>, <Narasimhan.V@....com>, Shuah Khan
 <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2] selftests/ftrace: Convert poll to a gen_file


Shuah,

Can you take this through your tree?

-- Steve


On Wed, 9 Apr 2025 12:48:55 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Wed, 9 Apr 2025 04:46:32 +0000
> Ayush Jain <Ayush.jain3@....com> wrote:
> 
> > Poll program is a helper to ftracetest, thus make it a
> > generic file and remove it from being run as a test.
> > 
> > Currently when executing tests using
> >     $ make run_tests
> >       CC       poll
> >     TAP version 13
> >     1..2
> >     # timeout set to 0
> >     # selftests: ftrace: poll
> >     # Error: Polling file is not specified
> >     not ok 1 selftests: ftrace: poll # exit=255
> > 
> > Fix this by using TEST_GEN_FILES to build the 'poll' binary as a helper
> > rather than as a test.
> > 
> > Fixes: 80c3e28528ff ("selftests/tracing: Add hist poll() support test")
> > 
> > Signed-off-by: Ayush Jain <Ayush.jain3@....com>  
> 
> Acked-by: Steven Rostedt (Google) <rostedt@...dmis.org>
> 
> -- Steve
> 
> > ---
> >  tools/testing/selftests/ftrace/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/testing/selftests/ftrace/Makefile b/tools/testing/selftests/ftrace/Makefile
> > index 49d96bb16355..7c12263f8260 100644
> > --- a/tools/testing/selftests/ftrace/Makefile
> > +++ b/tools/testing/selftests/ftrace/Makefile
> > @@ -6,6 +6,6 @@ TEST_PROGS := ftracetest-ktap
> >  TEST_FILES := test.d settings
> >  EXTRA_CLEAN := $(OUTPUT)/logs/*
> >  
> > -TEST_GEN_PROGS = poll
> > +TEST_GEN_FILES := poll
> >  
> >  include ../lib.mk  
>