linux-kernel - Re: [PATCH v6 02/11] dt-bindings: iio: adc: ad7768-1: add trigger-sources property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250507205040.3a1eec14@jic23-huawei>
Date: Wed, 7 May 2025 20:50:40 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Jonathan Santos <jonath4nns@...il.com>
Cc: 20250505163919.6d805db2@...23-huawei.smtp.subspace.kernel.org,
	Jonathan Santos <Jonathan.Santos@...log.com>,
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
	andy@...nel.org, nuno.sa@...log.com, Michael.Hennerich@...log.com,
	marcelo.schmitt@...log.com, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, marcelo.schmitt1@...il.com,
	linus.walleij@...aro.org, brgl@...ev.pl, lgirdwood@...il.com,
	broonie@...nel.org, dlechner@...libre.com
Subject: Re: [PATCH v6 02/11] dt-bindings: iio: adc: ad7768-1: add
 trigger-sources property

On Tue, 6 May 2025 16:16:37 -0300
Jonathan Santos <jonath4nns@...il.com> wrote:

> On 05/05, Jonathan Cameron wrote:
> > On Sun, 27 Apr 2025 21:12:16 -0300
> > Jonathan Santos <Jonathan.Santos@...log.com> wrote:
> >   
> ...
> > >  required:
> > >    - compatible
> > >    - reg
> > > @@ -65,7 +95,6 @@ required:
> > >    - vref-supply
> > >    - spi-cpol
> > >    - spi-cpha
> > > -  - adi,sync-in-gpios  
> > 
> > Maybe worth requiring oneOf adi,sync-in-gpios or trigger-sources? 
> >   
> 
> We cannot do that because we defined that self triggering is enabled
> when trigger-sources is omitted (is this case adi,sync-in-gpios is not
> present as well).
Ah. Fair enough.  More complex but we can constrain to never having
both adi,sync-in-gpios and trigger-sources at the same time.

> 
> > >  
> > >  patternProperties:
> > >    "^channel@([0-9]|1[0-5])$":
> > > diff --git a/include/dt-bindings/iio/adc/adi,ad7768-1.h b/include/dt-bindings/iio/adc/adi,ad7768-1.h
> > > new file mode 100644
> > > index 000000000000..34d92856a50b
> > > --- /dev/null
> > > +++ b/include/dt-bindings/iio/adc/adi,ad7768-1.h
> > > @@ -0,0 +1,10 @@
> > > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> > > +
> > > +#ifndef _DT_BINDINGS_ADI_AD7768_1_H
> > > +#define _DT_BINDINGS_ADI_AD7768_1_H
> > > +
> > > +#define AD7768_TRIGGER_SOURCE_SYNC_OUT  0
> > > +#define AD7768_TRIGGER_SOURCE_GPIO3     1
> > > +#define AD7768_TRIGGER_SOURCE_DRDY      2
> > > +
> > > +#endif /* _DT_BINDINGS_ADI_AD7768_1_H */  
> >