linux-kernel - Re: [PATCH] i2c: I2C_DESIGNWARE_AMDISP should depend on DRM_AMD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <336cb41c-a33a-4e8c-be4c-b032a4a1e4b7@amd.com>
Date: Wed, 7 May 2025 16:37:59 -0400
From: "Nirujogi, Pratap" <pnirujog@....com>
To: Geert Uytterhoeven <geert+renesas@...der.be>,
 Andi Shyti <andi.shyti@...nel.org>, Pratap Nirujogi
 <pratap.nirujogi@....com>, Bin Du <bin.du@....com>,
 Mario Limonciello <mario.limonciello@....com>,
 Venkata Narendra Kumar Gutta <vengutta@....com>
Cc: linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: I2C_DESIGNWARE_AMDISP should depend on DRM_AMD_ISP

Hi Geert,

Thanks for your patch.

On 5/6/2025 9:02 AM, Geert Uytterhoeven wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> The AMD Image Signal Processor I2C functionality is only present on AMD
> platforms with ISP support, and its platform device is instantiated by
> the AMD ISP driver.  Hence add a dependency on DRM_AMD_ISP, to prevent
> asking the user about this driver when configuring a kernel that does
> not support the AMD ISP.
> 
> Fixes: 63f0545cb1bf0840 ("i2c: amd-isp: Add ISP i2c-designware driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>   drivers/i2c/busses/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 865b760866ef42ba..7c348491e1bbac7c 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -594,6 +594,7 @@ config I2C_DESIGNWARE_PLATFORM
> 
>   config I2C_DESIGNWARE_AMDISP
>          tristate "Synopsys DesignWare Platform for AMDISP"
> +       depends on DRM_AMD_ISP || COMPILE_TEST
>          depends on I2C_DESIGNWARE_CORE
>          help
>            If you say yes to this option, support will be included for the
> --
> 2.43.0
> 
LGTM.

Reviewed-by: Pratap Nirujogi <pratap.nirujogi@....com>

Thanks,
Pratap