linux-kernel - Re: [PATCH] EISA: Move devlist.h out of obj to always

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025050716-unframed-unstuffed-842e@gregkh>
Date: Wed, 7 May 2025 07:00:34 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: Kees Cook <kees@...nel.org>, Alejandro Colomar <alx@...nel.org>,
	linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] EISA: Move devlist.h out of obj to always

On Tue, May 06, 2025 at 12:17:27PM -0700, Randy Dunlap wrote:
> 
> 
> On 5/6/25 11:51 AM, Kees Cook wrote:
> > On Tue, May 06, 2025 at 08:54:29AM -0700, Randy Dunlap wrote:
> >> Hi Kees,
> >>
> >> On 4/22/25 8:50 PM, Randy Dunlap wrote:
> >>>
> >>>
> >>> On 4/22/25 7:37 PM, Kees Cook wrote:
> >>>> I put devlist.h into the wrong Makefile macro ("obj") to get it included
> >>>> in "targets". Put it into "always" so nothing tries to link against it.
> >>>> Solves CONFIG_EISA=y i386 build failure:
> >>>>
> >>>> ld: vmlinux.a: member drivers/eisa/devlist.h in archive is not an object
> >>>>
> >>>> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> >>>> Closes: https://lore.kernel.org/all/4a8ba1d0-d2d9-41f8-abf1-d45ec8996d10@infradead.org
> >>>> Fixes: dd09eb0e2cc4 ("EISA: Increase length of device names")
> >>>> Signed-off-by: Kees Cook <kees@...nel.org>
> >>>
> >>> Acked-by: Randy Dunlap <rdunlap@...radead.org>
> >>> Tested-by: Randy Dunlap <rdunlap@...radead.org>
> >>>
> >>> Thanks.
> >>>
> >>
> >> Please merge this patch. The build failure is killing lots of i386 builds.
> >> Thanks.
> > 
> > AFAIK, this needs to go via Greg's tree, but I can see if I can send it
> > to Linus directly.
> > 
> > -Kees
> 
> Greg told me that it belongs to one of your trees, but Greg did
> merge the previous eisa/Makefile patch.

Ah, I thought that was in Kees's tree, sorry about that.  I'll take this
then, my fault.

greg k-h