linux-kernel - Re: [PATCH v6 13/22] rv: Add support for LTL monitors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250507170002.1abd3ce7@gandalf.local.home>
Date: Wed, 7 May 2025 17:00:02 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Nam Cao <namcao@...utronix.de>
Cc: Gabriele Monaco <gmonaco@...hat.com>,
 linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org,
 john.ogness@...utronix.de
Subject: Re: [PATCH v6 13/22] rv: Add support for LTL monitors

On Wed, 30 Apr 2025 13:02:28 +0200
Nam Cao <namcao@...utronix.de> wrote:

> diff --git a/kernel/trace/rv/rv_trace.h b/kernel/trace/rv/rv_trace.h
> index 99c3801616d4..f9fb848bae91 100644
> --- a/kernel/trace/rv/rv_trace.h
> +++ b/kernel/trace/rv/rv_trace.h
> @@ -127,6 +127,53 @@ DECLARE_EVENT_CLASS(error_da_monitor_id,
>  // Add new monitors based on CONFIG_DA_MON_EVENTS_ID here
>  
>  #endif /* CONFIG_DA_MON_EVENTS_ID */
> +#if CONFIG_LTL_MON_EVENTS_ID
> +TRACE_EVENT(event_ltl_monitor_id,

Needs to be:

#ifdef CONFIG_LTL_MON_EVENTS_ID

Otherwise I get this:

In file included from /work/git/test-linux.git/include/trace/trace_events.h:107,
                 from /work/git/test-linux.git/include/trace/define_trace.h:119:
/work/git/test-linux.git/kernel/trace/rv/./rv_trace.h:130:5: error: "CONFIG_LTL_MON_EVENTS_ID" is not defined, evaluates to 0 [-Werror=undef]
  130 | #if CONFIG_LTL_MON_EVENTS_ID

and it fails to build.

-- Steve