linux-kernel - Re: [PATCH] kernel/nsproxy: guard all put_*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250507212600.GZ2023217@ZenIV>
Date: Wed, 7 May 2025 22:26:00 +0100
From: Al Viro <viro@...iv.linux.org.uk>
To: Joel Savitz <jsavitz@...hat.com>
Cc: linux-kernel@...r.kernel.org, Christian Brauner <brauner@...nel.org>
Subject: Re: [PATCH] kernel/nsproxy: guard all put_*_ns() calls

On Wed, May 07, 2025 at 12:13:28PM -0400, Joel Savitz wrote:
> In free_nsproxy() and the error path of create_new_namespaces() all
> calls to put_*_ns() are guarded by a null pointer check except for
> put_cgroup_ns() and put_net(). When CONFIG_NET_NS or CONFIG_GROUP is
> unset, either of these functions may be called with a NULL argument.
> This may or may not be handled correctly, but at the very least it is
> certainly quicker to just perform the null check in all cases.

Why not simply make put_net(NULL) et.al. no-op instead?