linux-kernel - Re: [PATCH v5 6/9] x86/nmi: Prepare for the new NMI-source vector encoding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e5c6eff-8ae1-4265-8bf7-0173ed9b0ae7@intel.com>
Date: Wed, 7 May 2025 15:10:21 -0700
From: Sohil Mehta <sohil.mehta@...el.com>
To: Peter Zijlstra <peterz@...radead.org>
CC: <x86@...nel.org>, <linux-kernel@...r.kernel.org>, Xin Li <xin@...or.com>,
	"H . Peter Anvin" <hpa@...or.com>, Andy Lutomirski <luto@...nel.org>, "Thomas
 Gleixner" <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, "Borislav
 Petkov" <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>, "Sean
 Christopherson" <seanjc@...gle.com>, Arnaldo Carvalho de Melo
	<acme@...nel.org>, Namhyung Kim <namhyung@...nel.org>, Mark Rutland
	<mark.rutland@....com>, Alexander Shishkin
	<alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, "Ian
 Rogers" <irogers@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>, "Kan
 Liang" <kan.liang@...ux.intel.com>, Tony Luck <tony.luck@...el.com>, "Paolo
 Bonzini" <pbonzini@...hat.com>, Vitaly Kuznetsov <vkuznets@...hat.com>,
	"Rafael J . Wysocki" <rafael@...nel.org>, Daniel Lezcano
	<daniel.lezcano@...aro.org>, Zhang Rui <rui.zhang@...el.com>, Lukasz Luba
	<lukasz.luba@....com>, Steven Rostedt <rostedt@...dmis.org>, Masami Hiramatsu
	<mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Brian Gerst <brgerst@...il.com>, Andrew Cooper <andrew.cooper3@...rix.com>,
	"Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>, Jacob Pan
	<jacob.pan@...ux.microsoft.com>, Andi Kleen <ak@...ux.intel.com>, Kai Huang
	<kai.huang@...el.com>, Nikolay Borisov <nik.borisov@...e.com>,
	<linux-perf-users@...r.kernel.org>, <linux-edac@...r.kernel.org>,
	<kvm@...r.kernel.org>, <linux-pm@...r.kernel.org>,
	<linux-trace-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 6/9] x86/nmi: Prepare for the new NMI-source vector
 encoding

On 5/7/2025 2:17 AM, Peter Zijlstra wrote:
> On Tue, May 06, 2025 at 06:21:42PM -0700, Sohil Mehta wrote:

>> +	if (vector == NMI_VECTOR)
>> +		return APIC_DM_NMI;
>> +	else
> 
> Please drop that else, that's pointless.
> 

Will do.

>> +		return APIC_DM_FIXED | vector;
>> +}