linux-kernel - Re: [PATCH v1] ptp: ocp: Limit SMA/signal/freq counts in show/store functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202505080859.Ke4zJAh1-lkp@intel.com>
Date: Thu, 8 May 2025 06:49:44 +0800
From: kernel test robot <lkp@...el.com>
To: Sagi Maimon <maimon.sagi@...il.com>, jonathan.lemon@...il.com,
	vadim.fedorenko@...ux.dev, richardcochran@...il.com,
	andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, Sagi Maimon <maimon.sagi@...il.com>
Subject: Re: [PATCH v1] ptp: ocp: Limit SMA/signal/freq counts in show/store
 functions

Hi Sagi,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]
[also build test WARNING on net/main linus/master v6.15-rc5 next-20250507]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sagi-Maimon/ptp-ocp-Limit-SMA-signal-freq-counts-in-show-store-functions/20250506-161305
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250506080647.116702-1-maimon.sagi%40gmail.com
patch subject: [PATCH v1] ptp: ocp: Limit SMA/signal/freq counts in show/store functions
config: parisc-allmodconfig (https://download.01.org/0day-ci/archive/20250508/202505080859.Ke4zJAh1-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250508/202505080859.Ke4zJAh1-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505080859.Ke4zJAh1-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/ptp/ptp_ocp.c: In function 'ptp_ocp_summary_show':
>> drivers/ptp/ptp_ocp.c:4052:28: warning: '%d' directive writing between 1 and 11 bytes into a region of size 5 [-Wformat-overflow=]
    4052 |         sprintf(label, "GEN%d", nr + 1);
         |                            ^~
   In function '_signal_summary_show',
       inlined from 'ptp_ocp_summary_show' at drivers/ptp/ptp_ocp.c:4215:4:
   drivers/ptp/ptp_ocp.c:4052:24: note: directive argument in the range [-2147483639, 2147483647]
    4052 |         sprintf(label, "GEN%d", nr + 1);
         |                        ^~~~~~~
   drivers/ptp/ptp_ocp.c:4052:9: note: 'sprintf' output between 5 and 15 bytes into a destination of size 8
    4052 |         sprintf(label, "GEN%d", nr + 1);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/ptp/ptp_ocp.c: In function 'ptp_ocp_summary_show':
   drivers/ptp/ptp_ocp.c:4077:29: warning: '%d' directive writing between 1 and 11 bytes into a region of size 4 [-Wformat-overflow=]
    4077 |         sprintf(label, "FREQ%d", nr + 1);
         |                             ^~
   In function '_frequency_summary_show',
       inlined from 'ptp_ocp_summary_show' at drivers/ptp/ptp_ocp.c:4219:4:
   drivers/ptp/ptp_ocp.c:4077:24: note: directive argument in the range [-2147483640, 2147483647]
    4077 |         sprintf(label, "FREQ%d", nr + 1);
         |                        ^~~~~~~~
   drivers/ptp/ptp_ocp.c:4077:9: note: 'sprintf' output between 6 and 16 bytes into a destination of size 8
    4077 |         sprintf(label, "FREQ%d", nr + 1);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +4052 drivers/ptp/ptp_ocp.c

f67bf662d2cffa2 Jonathan Lemon 2021-09-14  4041  
b325af3cfab970e Jonathan Lemon 2022-03-10  4042  static void
b325af3cfab970e Jonathan Lemon 2022-03-10  4043  _signal_summary_show(struct seq_file *s, struct ptp_ocp *bp, int nr)
b325af3cfab970e Jonathan Lemon 2022-03-10  4044  {
b325af3cfab970e Jonathan Lemon 2022-03-10  4045  	struct signal_reg __iomem *reg = bp->signal_out[nr]->mem;
b325af3cfab970e Jonathan Lemon 2022-03-10  4046  	struct ptp_ocp_signal *signal = &bp->signal[nr];
b325af3cfab970e Jonathan Lemon 2022-03-10  4047  	char label[8];
b325af3cfab970e Jonathan Lemon 2022-03-10  4048  	bool on;
b325af3cfab970e Jonathan Lemon 2022-03-10  4049  	u32 val;
b325af3cfab970e Jonathan Lemon 2022-03-10  4050  
b325af3cfab970e Jonathan Lemon 2022-03-10  4051  	on = signal->running;
05fc65f3f5e45e8 Jonathan Lemon 2022-03-15 @4052  	sprintf(label, "GEN%d", nr + 1);
b325af3cfab970e Jonathan Lemon 2022-03-10  4053  	seq_printf(s, "%7s: %s, period:%llu duty:%d%% phase:%llu pol:%d",
b325af3cfab970e Jonathan Lemon 2022-03-10  4054  		   label, on ? " ON" : "OFF",
b325af3cfab970e Jonathan Lemon 2022-03-10  4055  		   signal->period, signal->duty, signal->phase,
b325af3cfab970e Jonathan Lemon 2022-03-10  4056  		   signal->polarity);
b325af3cfab970e Jonathan Lemon 2022-03-10  4057  
b325af3cfab970e Jonathan Lemon 2022-03-10  4058  	val = ioread32(&reg->enable);
b325af3cfab970e Jonathan Lemon 2022-03-10  4059  	seq_printf(s, " [%x", val);
b325af3cfab970e Jonathan Lemon 2022-03-10  4060  	val = ioread32(&reg->status);
b325af3cfab970e Jonathan Lemon 2022-03-10  4061  	seq_printf(s, " %x]", val);
b325af3cfab970e Jonathan Lemon 2022-03-10  4062  
b325af3cfab970e Jonathan Lemon 2022-03-10  4063  	seq_printf(s, " start:%llu\n", signal->start);
b325af3cfab970e Jonathan Lemon 2022-03-10  4064  }
b325af3cfab970e Jonathan Lemon 2022-03-10  4065  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki