linux-kernel - Re: [Upstream] [PATCH v2 2/2] arm64: dts: ti: k3-am62x-phyboard-lyra-gpio-fan: Update cooling maps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <db40cbe5-8ccd-426e-ac51-571086b4bdd4@phytec.de>
Date: Wed, 7 May 2025 08:38:17 +0300
From: Wadim Egorov <w.egorov@...tec.de>
To: Daniel Schultz <d.schultz@...tec.de>, nm@...com, vigneshr@...com,
 kristo@...nel.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: upstream@...ts.phytec.de
Subject: Re: [Upstream] [PATCH v2 2/2] arm64: dts: ti:
 k3-am62x-phyboard-lyra-gpio-fan: Update cooling maps

Am 06.05.25 um 14:41 schrieb Daniel Schultz:
> Rename 'main0_thermal_trip0' to a more descriptive name that
> includes 'fan', as the current name is too generic for a fan control
> trip point.
> 
> Move the fan to a new cooling map to avoid overwriting the passive
> trip point used for CPU frequency throttling when this overlay is
> enabled. Also, add the fan to the existing cooling map.
> 
> Signed-off-by: Daniel Schultz <d.schultz@...tec.de>

Reviewed-by: Wadim Egorov <w.egorov@...tec.de>

> ---
>   .../dts/ti/k3-am62x-phyboard-lyra-gpio-fan.dtso    | 14 ++++++++++++--
>   1 file changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62x-phyboard-lyra-gpio-fan.dtso b/arch/arm64/boot/dts/ti/k3-am62x-phyboard-lyra-gpio-fan.dtso
> index f0b2fd4165a7..1fd0aaff3193 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62x-phyboard-lyra-gpio-fan.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-am62x-phyboard-lyra-gpio-fan.dtso
> @@ -33,7 +33,7 @@ AM62X_IOPAD(0x0a4, PIN_OUTPUT, 7) /* (M22) GPMC0_DIR.GPIO0_40 */
>   &thermal_zones {
>   	main0_thermal: main0-thermal {
>   		trips {
> -			main0_thermal_trip0: main0-thermal-trip {
> +			main0_fan: main0-fan {
>   				temperature = <65000>;  /* millicelsius */
>   				hysteresis = <2000>;    /* millicelsius */
>   				type = "active";
> @@ -42,7 +42,17 @@ main0_thermal_trip0: main0-thermal-trip {
>   
>   		cooling-maps {
>   			map0 {
> -				trip = <&main0_thermal_trip0>;
> +				trip = <&main0_alert>;
> +				cooling-device =
> +					<&fan THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +					<&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +					<&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +					<&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +					<&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> +			};
> +
> +			map1 {
> +				trip = <&main0_fan>;
>   				cooling-device = <&fan THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
>   			};
>   		};