linux-kernel - Re: [PATCH 2/3] clocksource/drivers/timer-vt8500: Add watchdog functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABjd4YzmbQj2eDKS1YvdZFzwzP0v=2dwPsPUqZqL9=Gc6zatFw@mail.gmail.com>
Date: Wed, 7 May 2025 09:46:47 +0400
From: Alexey Charkov <alchark@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Daniel Lezcano <daniel.lezcano@...aro.org>, Thomas Gleixner <tglx@...utronix.de>, 
	Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org
Subject: Re: [PATCH 2/3] clocksource/drivers/timer-vt8500: Add watchdog functionality

On Wed, May 7, 2025 at 8:33 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 06/05/2025 22:06, Alexey Charkov wrote:
> > VIA/WonderMedia system timer IP can generate a watchdog reset when its
> > clocksource counter matches the value in the match register 0 and
> > watchdog function is enabled. For this to work, obvously the clock event
> > device must use a different match register (1~3) and respective interrupt.
> >
> > Check if at least two interrupts are provided by the device tree, then use
> > match register 1 for system clock events and match register 0 for watchdog
> > respectively.
> >
> > Signed-off-by: Alexey Charkov <alchark@...il.com>
> > ---
> >  drivers/clocksource/Kconfig        |  6 +++-
> >  drivers/clocksource/timer-vt8500.c | 58 ++++++++++++++++++++++++++++++++++----
> >  2 files changed, 58 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> > index 487c8525996724fbf9c6e9726dabb478d86513b9..e4f9aade058af1adc279274c6c711658f9f4cd0a 100644
> > --- a/drivers/clocksource/Kconfig
> > +++ b/drivers/clocksource/Kconfig
> > @@ -177,9 +177,13 @@ config TEGRA186_TIMER
> >
> >  config VT8500_TIMER
> >       bool "VT8500 timer driver" if COMPILE_TEST
> > +     depends on ARCH_VT8500 || COMPILE_TEST
>
> Does not look related to this patch.

Will drop in v2.

> >       depends on HAS_IOMEM
> > +     select WATCHDOG
>
> Drivers are not supposed to select user-visible symbols.

Fair enough, thanks. Will add a separate nested user selectable option
for the watchdog function and make it depend on both the driver itself
and the watchdog core.

Best regards,
Alexey