linux-kernel - Re: [PATCH v5 08/12] gpio: aggregator: export symbols of the GPIO forwarder library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdRp7RG-YCAL2Jx4uXsT2RVQNeu-MxPB5pWRq8TqtsSXw@mail.gmail.com>
Date: Wed, 7 May 2025 09:29:39 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Thomas Richard <thomas.richard@...tlin.com>
Cc: Linus Walleij <linus.walleij@...aro.org>, 
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Bartosz Golaszewski <brgl@...ev.pl>, 
	Geert Uytterhoeven <geert+renesas@...der.be>, Kees Cook <kees@...nel.org>, 
	Andy Shevchenko <andy@...nel.org>, linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	thomas.petazzoni@...tlin.com, DanieleCleri@...on.eu, GaryWang@...on.com.tw, 
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH v5 08/12] gpio: aggregator: export symbols of the GPIO
 forwarder library

On Tue, May 6, 2025 at 6:21 PM Thomas Richard
<thomas.richard@...tlin.com> wrote:
>
> Export all symbols and create header file for the GPIO forwarder library.
> It will be used in the next changes.

...

> +/**
> + * gpio_fwd_to_irq - Return the IRQ corresponding to a GPIO forwarder line
> + * @chip: GPIO chip in the forwarder
> + * @offset: the offset of the line
> + *
> + * Returns: The IRQ corresponding to the passed line, or an error code in case

"The Linux IRQ..." since it's a logical number and 0 can't be ever returned.

> + * of error.
> + */

...

> +/**
> + * gpio_fwd_gpio_add - Add a GPIO in the forwarder

forwarder

> + * @fwd: GPIO forwarder
> + * @desc: GPIO decriptor to register

descriptor

> + * @offset: offset for the GPIO in the forwarder
> + *
> + * Returns: 0 on success, or negative errno on failure.
> + */

Please, spellcheck all of the comments.

...

> +#ifndef __LINUX_GPIO_FORWARDER_H
> +#define __LINUX_GPIO_FORWARDER_H

> +#include <linux/gpio/consumer.h>
> +#include <linux/gpio/driver.h>

These are not used (at least as of this patch).

+ struct gpio_chip;

> +struct gpiochip_fwd;

> +struct gpio_chip *gpio_fwd_get_gpiochip(struct gpiochip_fwd *fwd);
> +
> +int gpio_fwd_get_direction(struct gpio_chip *chip, unsigned int offset);
> +
> +int gpio_fwd_direction_input(struct gpio_chip *chip, unsigned int offset);
> +
> +int gpio_fwd_direction_output(struct gpio_chip *chip, unsigned int offset,
> +                             int value);
> +
> +int gpio_fwd_get(struct gpio_chip *chip, unsigned int offset);
> +
> +int gpio_fwd_get_multiple_locked(struct gpio_chip *chip, unsigned long *mask,
> +                                unsigned long *bits);
> +
> +int gpio_fwd_set(struct gpio_chip *chip, unsigned int offset, int value);
> +
> +int gpio_fwd_set_multiple_locked(struct gpio_chip *chip, unsigned long *mask,
> +                                unsigned long *bits);
> +
> +int gpio_fwd_set_config(struct gpio_chip *chip, unsigned int offset,
> +                       unsigned long config);
> +
> +int gpio_fwd_to_irq(struct gpio_chip *chip, unsigned int offset);
> +
> +struct gpiochip_fwd *devm_gpio_fwd_alloc(struct device *dev,
> +                                        unsigned int ngpios);
> +
> +int gpio_fwd_gpio_add(struct gpiochip_fwd *fwd,
> +                     struct gpio_desc *desc, unsigned int offset);
> +
> +int gpio_fwd_register(struct gpiochip_fwd *fwd);
> +
> +#endif

-- 
With Best Regards,
Andy Shevchenko