linux-kernel - Re: [PATCH 00/14] iio: remove bits_per

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4678d4f0c5634f8709f84745054ae16484617b8d.camel@gmail.com>
Date: Wed, 07 May 2025 07:28:12 +0100
From: Nuno Sá <noname.nuno@...il.com>
To: David Lechner <dlechner@...libre.com>, Lars-Peter Clausen
 <lars@...afoo.de>,  Michael Hennerich <Michael.Hennerich@...log.com>, Nuno
 Sá <nuno.sa@...log.com>, Esteban Blanc
 <eblanc@...libre.com>, Jonathan Cameron <jic23@...nel.org>, Andy Shevchenko
 <andy@...nel.org>, Oleksij Rempel <o.rempel@...gutronix.de>, 
 kernel@...gutronix.de, Song Qiang <songqiang1304521@...il.com>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/14] iio: remove bits_per_word = 8 assignments

On Mon, 2025-05-05 at 14:20 -0500, David Lechner wrote:
> While grepping the IIO subsystem for drivers that set bits_per_word to
> unusual values to check for potential bugs, I found it to be a bit of a
> nuisance that 2/3s of the matches were setting it to the default value
> of 8. So here is a series removing the unnecessary assignments.
> 
> ---

LGTM,

Reviewed-by: Nuno Sá <nuno.sa@...log.com>

> David Lechner (14):
>       iio: adc: ad4030: remove bits_per_word = 8
>       iio: adc: ti-tsc2046: remove bits_per_word = 8
>       iio: chemical: bme680_spi: remove bits_per_word = 8
>       iio: dac: ad5761: remove bits_per_word = 8
>       iio: dac: ad5766: remove bits_per_word = 8
>       iio: dac: ad5791: remove bits_per_word = 8
>       iio: dac: ltc2688: remove bits_per_word = 8
>       iio: gyro: adxrs450: remove bits_per_word = 8
>       iio: imu: adis: remove bits_per_word = 8
>       iio: magnetometer: hmc5843_spi: remove bits_per_word = 8
>       iio: magnetometer: rm3100-spi: remove bits_per_word = 8
>       iio: pressure: bmp280-spi: remove bits_per_word = 8
>       iio: pressure: ms5611_spi: remove bits_per_word = 8
>       iio: pressure: zpa2326_spi: remove bits_per_word = 8
> 
>  drivers/iio/adc/ad4030.c               | 4 ----
>  drivers/iio/adc/ti-tsc2046.c           | 1 -
>  drivers/iio/chemical/bme680_spi.c      | 8 --------
>  drivers/iio/dac/ad5761.c               | 2 --
>  drivers/iio/dac/ad5766.c               | 2 --
>  drivers/iio/dac/ad5791.c               | 2 --
>  drivers/iio/dac/ltc2688.c              | 2 --
>  drivers/iio/gyro/adxrs450.c            | 5 -----
>  drivers/iio/imu/adis.c                 | 9 ---------
>  drivers/iio/imu/adis_buffer.c          | 3 ---
>  drivers/iio/magnetometer/hmc5843_spi.c | 1 -
>  drivers/iio/magnetometer/rm3100-spi.c  | 1 -
>  drivers/iio/pressure/bmp280-spi.c      | 8 --------
>  drivers/iio/pressure/ms5611_spi.c      | 1 -
>  drivers/iio/pressure/zpa2326_spi.c     | 1 -
>  15 files changed, 50 deletions(-)
> ---
> base-commit: 7e9a82ab5b861d3c33c99a22c1245a5b262ee502
> change-id: 20250505-iio-remove-bits_per_word-8-db80654b1c17
> 
> Best regards,