linux-kernel - RE: [EXT] Re: [PATCH v2 1/2] dt-bindings: rtc: Add pcf85053a support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <AM0PR04MB65156BE2EE9C7EF14991892CE788A@AM0PR04MB6515.eurprd04.prod.outlook.com>
Date: Wed, 7 May 2025 07:31:03 +0000
From: Pankit Garg <pankit.garg@....com>
To: Conor Dooley <conor@...nel.org>
CC: "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "robh@...nel.org"
	<robh@...nel.org>, "alexandre.belloni@...tlin.com"
	<alexandre.belloni@...tlin.com>, Vikash Bansal <vikash.bansal@....com>,
	Priyanka Jain <priyanka.jain@....com>, Daniel Aguirre
	<daniel.aguirre@....com>, Shashank Rebbapragada
	<shashank.rebbapragada@....com>, Aman Kumar Pandey <aman.kumarpandey@....com>
Subject: RE: [EXT] Re: [PATCH v2 1/2] dt-bindings: rtc: Add pcf85053a support



> -----Original Message-----
> From: Conor Dooley <conor@...nel.org>
> Sent: Tuesday, May 6, 2025 9:19 PM
> To: Pankit Garg <pankit.garg@....com>
> Cc: linux-rtc@...r.kernel.org; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org; conor+dt@...nel.org; robh@...nel.org;
> alexandre.belloni@...tlin.com; Vikash Bansal <vikash.bansal@....com>;
> Priyanka Jain <priyanka.jain@....com>; Daniel Aguirre
> <daniel.aguirre@....com>; Shashank Rebbapragada
> <shashank.rebbapragada@....com>; Aman Kumar Pandey
> <aman.kumarpandey@....com>
> Subject: [EXT] Re: [PATCH v2 1/2] dt-bindings: rtc: Add pcf85053a support
> 
> On Tue, May 06, 2025 at 03:18:14PM +0530, Pankit Garg wrote:
> > Add device tree bindings for NXP PCF85053a RTC chip.
> >
> > Signed-off-by: Pankit Garg <pankit.garg@....com>
> > ---
> > V1 -> V2: Handled dt-bindings by trivial-rtc.yaml
> >
> > ---
> >  Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 2 ++
> >  MAINTAINERS                                            | 5 +++++
> >  2 files changed, 7 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> > b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> > index 7330a7200831..47be7bbbfedd 100644
> > --- a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> > +++ b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> > @@ -65,6 +65,8 @@ properties:
> >        - microcrystal,rv8523
> >        # NXP LPC32xx SoC Real-time Clock
> >        - nxp,lpc3220-rtc
> > +      # NXP PCF85053A Real Time Clock Module with I2C-Bus
> > +      - nxp,pcf85053a
> 
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> 
> >        # I2C bus SERIAL INTERFACE REAL-TIME CLOCK IC
> >        - ricoh,r2025sd
> >        # I2C bus SERIAL INTERFACE REAL-TIME CLOCK IC
> 
> > diff --git a/MAINTAINERS b/MAINTAINERS index
> > 0737dcb2e411..d39fc05c6454 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -17782,6 +17782,11 @@ S:	Maintained
> >  F:	Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml
> >  F:	sound/soc/codecs/tfa989x.c
> >
> > +NXP RTC PCF85053A DRIVER
> > +M:	Pankit Garg<pankit.garg@....com>
> > +L:	linux-kernel@...r.kernel.org
> > +S:	Maintained
> 
> This looks like a hang-over from your v1 and should really be moved to the
> patch adding the driver.

Thanks for reviewing the patch. I have pushed v3, in which I have handled this thing.