linux-kernel - Re: cleanup AOP_WRITEPAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9720676-5e03-4298-8811-f6cd0dc8ea0c@kernel.org>
Date: Wed, 7 May 2025 16:13:02 +0800
From: Chao Yu <chao@...nel.org>
To: Christoph Hellwig <hch@....de>
Cc: chao@...nel.org, Jaegeuk Kim <jaegeuk@...nel.org>,
 linux-f2fs-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: cleanup AOP_WRITEPAGE_ACTIVATE use in f2fs

On 5/7/25 15:48, Christoph Hellwig wrote:
> On Wed, May 07, 2025 at 03:38:20PM +0800, Chao Yu wrote:
>> On 5/5/25 17:25, Christoph Hellwig wrote:
>>> Hi all,
>>>
>>> this almost entirely cleans up usage of AOP_WRITEPAGE_ACTIVATE in f2fs.
>>>
>>> f2fs_sync_node_pages can still return it in a way that is not handled
>>> by any caller and eventually is propagated to userspace.  This does look
>>> like a bug and needs attention by someone who actually knows the code.
>>
>> Oh, I guess this is a bug, thanks for catching this.
>>
>> Anyway, let me fix this based on your patchset.
> 
> I'll resend a fixed version later today, maybe wait for that.

I've submitted a patch, maybe you can rebase new version on it?

https://lore.kernel.org/linux-f2fs-devel/20250507080838.882657-1-chao@kernel.org

https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git/commit/?h=bugfix/common&id=a0b7dfb634f98b88875e7bc3166159d2abc7f164

Thanks,