linux-kernel - Re: [PATCH net-next v2 3/5] amd-xgbe: add support for new XPCS routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202505071632.XaIo3kvL-lkp@intel.com>
Date: Wed, 7 May 2025 16:37:53 +0800
From: kernel test robot <lkp@...el.com>
To: Raju Rangoju <Raju.Rangoju@....com>, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Shyam-sundar.S-k@....com,
	Raju Rangoju <Raju.Rangoju@....com>,
	Sudheesh Mavila <sudheesh.mavila@....com>
Subject: Re: [PATCH net-next v2 3/5] amd-xgbe: add support for new XPCS
 routines

Hi Raju,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Raju-Rangoju/amd-xgbe-reorganize-the-code-of-XPCS-access/20250428-230635
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250428150235.2938110-4-Raju.Rangoju%40amd.com
patch subject: [PATCH net-next v2 3/5] amd-xgbe: add support for new XPCS routines
config: i386-buildonly-randconfig-002-20250429 (https://download.01.org/0day-ci/archive/20250507/202505071632.XaIo3kvL-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250507/202505071632.XaIo3kvL-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505071632.XaIo3kvL-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/net/ethernet/amd/xgbe/xgbe-dev.c: In function 'xgbe_write_mmd_regs_v3':
>> drivers/net/ethernet/amd/xgbe/xgbe-dev.c:1110:17: error: implicit declaration of function 'pci_err'; did you mean 'pr_err'? [-Werror=implicit-function-declaration]
    1110 |                 pci_err(dev, "Failed to write data 0x%x\n", index);
         |                 ^~~~~~~
         |                 pr_err
   cc1: some warnings being treated as errors


vim +1110 drivers/net/ethernet/amd/xgbe/xgbe-dev.c

  1094	
  1095	static void xgbe_write_mmd_regs_v3(struct xgbe_prv_data *pdata, int prtad,
  1096					   int mmd_reg, int mmd_data)
  1097	{
  1098		unsigned int pci_mmd_data, hi_mask, lo_mask;
  1099		unsigned int mmd_address, index, offset;
  1100		struct pci_dev *dev;
  1101		int ret;
  1102	
  1103		dev = pdata->pcidev;
  1104		mmd_address = xgbe_get_mmd_address(pdata, mmd_reg);
  1105	
  1106		xgbe_get_pcs_index_and_offset(pdata, mmd_address, &index, &offset);
  1107	
  1108		ret = amd_smn_write(0, (pdata->smn_base + pdata->xpcs_window_sel_reg), index);
  1109		if (ret) {
> 1110			pci_err(dev, "Failed to write data 0x%x\n", index);
  1111			return;
  1112		}
  1113	
  1114		ret = amd_smn_read(0, pdata->smn_base + offset, &pci_mmd_data);
  1115		if (ret) {
  1116			pci_err(dev, "Failed to read data\n");
  1117			return;
  1118		}
  1119	
  1120		if (offset % 4) {
  1121			hi_mask = FIELD_PREP(XGBE_GEN_HI_MASK, mmd_data);
  1122			lo_mask = FIELD_GET(XGBE_GEN_LO_MASK, pci_mmd_data);
  1123		} else {
  1124			hi_mask = FIELD_PREP(XGBE_GEN_HI_MASK,
  1125					     FIELD_GET(XGBE_GEN_HI_MASK, pci_mmd_data));
  1126			lo_mask = FIELD_GET(XGBE_GEN_LO_MASK, mmd_data);
  1127		}
  1128	
  1129		pci_mmd_data = hi_mask | lo_mask;
  1130	
  1131		ret = amd_smn_write(0, (pdata->smn_base + pdata->xpcs_window_sel_reg), index);
  1132		if (ret) {
  1133			pci_err(dev, "Failed to write data 0x%x\n", index);
  1134			return;
  1135		}
  1136	
  1137		ret = amd_smn_write(0, (pdata->smn_base + offset), pci_mmd_data);
  1138		if (ret) {
  1139			pci_err(dev, "Failed to write data 0x%x\n", pci_mmd_data);
  1140			return;
  1141		}
  1142	}
  1143	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki