linux-kernel - Re: [PATCH] MAINTAINERS: add mm GUP section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13a32f52-dc5c-45ef-b45a-585586868509@lucifer.local>
Date: Wed, 7 May 2025 10:23:34 +0100
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: Uladzislau Rezki <urezki@...il.com>
Cc: David Hildenbrand <david@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jason Gunthorpe <jgg@...dia.com>, John Hubbard <jhubbard@...dia.com>,
        Peter Xu <peterx@...hat.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Vlastimil Babka <vbabka@...e.cz>
Subject: Re: [PATCH] MAINTAINERS: add mm GUP section

+cc Vlastimil for page_alloc.c stuff.

On Wed, May 07, 2025 at 11:02:00AM +0200, Uladzislau Rezki wrote:
> On Wed, May 07, 2025 at 10:05:58AM +0200, David Hildenbrand wrote:
> > On 07.05.25 01:21, Andrew Morton wrote:
> > > On Tue,  6 May 2025 18:36:01 +0100 Lorenzo Stoakes <lorenzo.stoakes@...cle.com> wrote:
> > >
> > > > As part of the ongoing efforts to sub-divide memory management
> > > > maintainership and reviewership, establish a section for GUP (Get User
> > > > Pages) support and add appropriate maintainers and reviewers.
> > > >
> > >
> > > Thanks, I was wondering about that.
> >
> > Thanks Lorenzo for driving this!
> >
> > Acked-by: David Hildenbrand <david@...hat.com>

Thanks David!

Am trying to strike while the iron is hot post-lsf and discuss with people and
set things in motion :)

> >
> > >
> > > (looks at vmscan.c)
> >
> > Current maintainers (mm/unstable) on 20 biggest files in mm, Andrew is
> > implicit:
> >
> >  $ find mm -name "*.c" -type f | xargs wc -l | sort -n -r | head -20
> >  198195 total
> >    7937 mm/hugetlb.c		# Muchun
> >    7881 mm/slub.c		# Christoph/David/Vlastimil
> >    7745 mm/vmscan.c		#

This is, as Andrew rightly points out, a key one, I will have a look around
the git history and put something together here. I'm not sure if we will
get an M here, but at least can populate some reviewers.

> >    7424 mm/page_alloc.c		#

Yeah Vlastimil put effort into sorting out reviewers here (thanks
Vlastimil!) but nobody's stepped up for an M yet :)

> >    7166 mm/memory.c		# David
> >    5962 mm/shmem.c		# Hugh
> >    5553 mm/memcontrol.c		# Johannes/Roman/Shakeel
> >    5245 mm/vmalloc.c		#

As discussed below 100% Ulad is very clearly the right guy for M (and who
has graciously offered his services as such) :>)

Ulad - do you want to send a patch upgrading yourself there? cc me and
David, I will happily ack of course, and I suspect David as well!

> >    4703 mm/huge_memory.c	# David
> >    4538 mm/filemap.c		# Willy
> >    3964 mm/swapfile.c		#

The various discussions at LSF lend themselves to suggesting people here,
can take a look at this also.

> >    3871 mm/ksm.c		#

As per discussion below, thanks for suggesting yourself David, I hope this
is a case of 'well de facto I am maintaining this' rather than taking
anything new on, as I worry about how much your workload involves :P

I will sniff around the git history too and put something together.

> >    3720 mm/gup.c		# David
> >    3675 mm/mempolicy.c		#

Ack below, and will take a look here also.

> >    3371 mm/percpu.c		# Dennis/Tejun/Christoph
> >    3370 mm/compaction.c		#

As you say lots of R's which is good.

As per below would you want M for this?

I will take a look also.

> >    3197 mm/page-writeback.c	# Willy
> >    3097 mm/vma.c		# Liam/Lorenzo
> >    2988 mm/rmap.c		# David/Lorenzo

> >
> > I've been messing with KSM for a long time, so I could easily jump in as
> > maintainer for that. Probably we want page migration (incl. mempolicy?) as a
> > separate entry. I've been messing with that as well (and will be messing
> > more), so I could jump in for that as well.
> >
> > For page allocator stuff (incl. compaction) we at least have plenty of
> > reviewers now. For vmalloc we at least have Uladzislau as single reviewer.
> >
> > vmscan.c and vmalloc.c really need some love.
> >
> As for "vmalloc.c" i can jump in as an extra maintainer aside with
> Andrew if no objections.

Entirely the opposite of an objection, I'd be aghast if you weren't a
maintainer there, thank you for your excellent work in vmalloc, you're a
top chap and we're very lucky to have you working on this!

>
> --
> Uladzislau Rezki

Cheers, Lorenzo