linux-kernel - Re: [PATCH net-next 4/4] riscv: dts: sophgo: add ethernet GMAC device for sg2042

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MA0P287MB2262AE2E8C2765AFBE6D41DAFE88A@MA0P287MB2262.INDP287.PROD.OUTLOOK.COM>
Date: Wed, 7 May 2025 09:47:24 +0800
From: Chen Wang <unicorn_wang@...look.com>
To: Inochi Amaoto <inochiama@...il.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Paul Walmsley
 <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>,
 Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Richard Cochran <richardcochran@...il.com>, Guo Ren <guoren@...nel.org>,
 Thomas Gleixner <tglx@...utronix.de>,
 Uwe Kleine-König <u.kleine-koenig@...libre.com>,
 "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
 Romain Gantois <romain.gantois@...tlin.com>,
 Joe Hattori <joe@...is.s.u-tokyo.ac.jp>, Lothar Rubusch
 <l.rubusch@...il.com>, Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
 Giuseppe Cavallaro <peppe.cavallaro@...com>,
 Jose Abreu <joabreu@...opsys.com>
Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, sophgo@...ts.linux.dev,
 linux-riscv@...ts.infradead.org, linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, Yixun Lan <dlan@...too.org>,
 Longbin Li <looong.bin@...il.com>, Han Gao <rabenda.cn@...il.com>
Subject: Re: [PATCH net-next 4/4] riscv: dts: sophgo: add ethernet GMAC device
 for sg2042

On 2025/5/6 17:32, Inochi Amaoto wrote:
> Add ethernet GMAC device node for the sg2042.
>
> Signed-off-by: Inochi Amaoto <inochiama@...il.com>
> Tested-by: Han Gao <rabenda.cn@...il.com>
> ---
>   arch/riscv/boot/dts/sophgo/sg2042.dtsi | 62 ++++++++++++++++++++++++++
>   1 file changed, 62 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/sophgo/sg2042.dtsi b/arch/riscv/boot/dts/sophgo/sg2042.dtsi
> index f61de4788475..886c13cef6ba 100644
> --- a/arch/riscv/boot/dts/sophgo/sg2042.dtsi
> +++ b/arch/riscv/boot/dts/sophgo/sg2042.dtsi
> @@ -543,6 +543,68 @@ uart0: serial@...0000000 {
>   			status = "disabled";
>   		};
>   
> +		gmac0: ethernet@...0026000 {
> +			compatible = "sophgo,sg2042-dwmac", "snps,dwmac-5.00a";
> +			reg = <0x70 0x40026000 0x0 0x4000>;
> +			clocks = <&clkgen GATE_CLK_AXI_ETH0>,
> +				 <&clkgen GATE_CLK_PTP_REF_I_ETH0>,
> +				 <&clkgen GATE_CLK_TX_ETH0>;
> +			clock-names = "stmmaceth", "ptp_ref", "tx";
> +			dma-noncoherent;
> +			interrupt-parent = <&intc>;
> +			interrupts = <132 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupt-names = "macirq";
> +			resets = <&rstgen RST_ETH0>;
> +			reset-names = "stmmaceth";
> +			snps,multicast-filter-bins = <0>;
> +			snps,perfect-filter-entries = <1>;
> +			snps,aal;
> +			snps,tso;
> +			snps,txpbl = <32>;
> +			snps,rxpbl = <32>;
> +			snps,mtl-rx-config = <&gmac0_mtl_rx_setup>;
> +			snps,mtl-tx-config = <&gmac0_mtl_tx_setup>;
> +			snps,axi-config = <&gmac0_stmmac_axi_setup>;
> +			status = "disabled";
> +
> +			mdio {
> +				compatible = "snps,dwmac-mdio";
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +			};
> +
> +			gmac0_mtl_rx_setup: rx-queues-config {
> +				snps,rx-queues-to-use = <8>;
> +				snps,rx-sched-wsp;
> +				queue0 {};
> +				queue1 {};
> +				queue2 {};
> +				queue3 {};
> +				queue4 {};
> +				queue5 {};
> +				queue6 {};
> +				queue7 {};
> +			};
> +
> +			gmac0_mtl_tx_setup: tx-queues-config {
> +				snps,tx-queues-to-use = <8>;
> +				queue0 {};
> +				queue1 {};
> +				queue2 {};
> +				queue3 {};
> +				queue4 {};
> +				queue5 {};
> +				queue6 {};
> +				queue7 {};
> +			};
> +
> +			gmac0_stmmac_axi_setup: stmmac-axi-config {
> +				snps,blen = <16 8 4 0 0 0 0>;
> +				snps,wr_osr_lmt = <1>;
> +				snps,rd_osr_lmt = <2>;
> +			};
> +		};
> +

LGTM.

Reviewed-by: Chen Wang <unicorn_wang@...look.com>

Thanks,

Chen

>   		emmc: mmc@...002a000 {
>   			compatible = "sophgo,sg2042-dwcmshc";
>   			reg = <0x70 0x4002a000 0x0 0x1000>;