linux-kernel - Re: [PATCH v7] PCI: hotplug: Add a generic RAS tracepoint for hotplug event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250507120914.000001c8@huawei.com>
Date: Wed, 7 May 2025 12:09:14 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Shuai Xue <xueshuai@...ux.alibaba.com>
CC: <rostedt@...dmis.org>, <lukas@...ner.de>, <linux-pci@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-edac@...r.kernel.org>,
	<linux-trace-kernel@...r.kernel.org>, <helgaas@...nel.org>,
	<bhelgaas@...gle.com>, <tony.luck@...el.com>, <bp@...en8.de>,
	<mhiramat@...nel.org>, <mathieu.desnoyers@...icios.com>, <oleg@...hat.com>,
	<naveen@...nel.org>, <davem@...emloft.net>, <anil.s.keshavamurthy@...el.com>,
	<mark.rutland@....com>, <peterz@...radead.org>,
	<tianruidong@...ux.alibaba.com>
Subject: Re: [PATCH v7] PCI: hotplug: Add a generic RAS tracepoint for
 hotplug event

On Wed,  7 May 2025 09:15:35 +0800
Shuai Xue <xueshuai@...ux.alibaba.com> wrote:

> Hotplug events are critical indicators for analyzing hardware health,
> particularly in AI supercomputers where surprise link downs can
> significantly impact system performance and reliability.
> 
> To this end, define a new TRACING_SYSTEM named pci, add a generic RAS
> tracepoint for hotplug event to help healthy check, and generate
> tracepoints for pcie hotplug event. Add enum pci_hotplug_event in
> include/uapi/linux/pci.h so applications like rasdaemon can register
> tracepoint event handlers for it.
> 
> The output like below:
> 
> $ echo 1 > /sys/kernel/debug/tracing/events/pci/pci_hp_event/enable
> $ cat /sys/kernel/debug/tracing/trace_pipe
>     <...>-206     [001] .....    40.373870: pci_hp_event: 0000:00:02.0 slot:10, event:Link Down
> 
>     <...>-206     [001] .....    40.374871: pci_hp_event: 0000:00:02.0 slot:10, event:Card not present
> 
> Suggested-by: Lukas Wunner <lukas@...ner.de>
> Suggested-by: Steven Rostedt <rostedt@...dmis.org>
> Reviewed-by: Lukas Wunner <lukas@...ner.de>
> Signed-off-by: Shuai Xue <xueshuai@...ux.alibaba.com>
FWIW looks good to me.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

Any userspace tooling planned for this?