linux-kernel - RE: questions about smu_mode2_reset_is_support and smu_v13_0_init_display

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DM4PR12MB5165D85BD85BC8FC8BF7A3B48E88A@DM4PR12MB5165.namprd12.prod.outlook.com>
Date: Wed, 7 May 2025 02:21:48 +0000
From: "Feng, Kenneth" <Kenneth.Feng@....com>
To: "Dr. David Alan Gilbert" <linux@...blig.org>, "Deucher, Alexander"
	<Alexander.Deucher@....com>, "Koenig, Christian" <Christian.Koenig@....com>
CC: "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: questions about smu_mode2_reset_is_support and
 smu_v13_0_init_display_count

[AMD Official Use Only - AMD Internal Distribution Only]

Hello Dave,
smu_v13_0_init_display_count() is obsolete on smu13 series. It will be removed.
Secondly, with cod evolving, all of below can be removed as well.
  sienna_cichlid_is_mode2_reset_supported,
  aldebaran_is_mode2_reset_supported,
  smu_v13_0_6_is_mode2_reset_supported
Thanks.



-----Original Message-----
From: Dr. David Alan Gilbert <linux@...blig.org>
Sent: Wednesday, May 7, 2025 8:32 AM
To: Deucher, Alexander <Alexander.Deucher@....com>; Feng, Kenneth <Kenneth.Feng@....com>; Koenig, Christian <Christian.Koenig@....com>
Cc: amd-gfx@...ts.freedesktop.org; linux-kernel@...r.kernel.org
Subject: questions about smu_mode2_reset_is_support and smu_v13_0_init_display_count

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


Hi,
  I noticed two functions that are unused but I wasn't sure what to do with them:

smu_v13_0_init_display_count() isn't called/wired up, where as the
v11 version is wired up:

 drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
     3574:      .init_display_count = smu_v11_0_init_display_count,

so is v13 really unused or should it be wired up in a similar way?

secondly, smu_mode2_reset_is_support() is uncalled, but it's the only caller through the mode2_reset_is_support() function pointer; so if smu_mode2_reset_is_support() was deleted, does it then make sense to clean up all of
  sienna_cichlid_is_mode2_reset_supported,
  aldebaran_is_mode2_reset_supported,
  smu_v13_0_6_is_mode2_reset_supported

which that function pointer is sett to.

Thanks in advance,

Dave

--
 -----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/