linux-kernel - [PATCH v3 2/3] configfs: Do not override creating attribute file failure in populate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250507-fix_configfs-v3-2-fe2d96de8dc4@quicinc.com>
Date: Wed, 07 May 2025 19:50:26 +0800
From: Zijun Hu <zijun_hu@...oud.com>
To: Joel Becker <jlbec@...lplan.org>, 
 Pantelis Antoniou <pantelis.antoniou@...sulko.com>, 
 Al Viro <viro@...iv.linux.org.uk>, Andreas Hindborg <a.hindborg@...nel.org>, 
 Breno Leitao <leitao@...ian.org>
Cc: Zijun Hu <zijun_hu@...oud.com>, linux-kernel@...r.kernel.org, 
 Zijun Hu <quic_zijuhu@...cinc.com>, stable@...r.kernel.org
Subject: [PATCH v3 2/3] configfs: Do not override creating attribute file
 failure in populate_attrs()

From: Zijun Hu <quic_zijuhu@...cinc.com>

populate_attrs() may override failure for creating attribute files
by success for creating subsequent bin attribute files, and have
wrong return value.

Fix by creating bin attribute files under successfully creating
attribute files.

Fixes: 03607ace807b ("configfs: implement binary attributes")
Cc: stable@...r.kernel.org
Reviewed-by: Joel Becker <jlbec@...lplan.org>
Reviewed-by: Breno Leitao <leitao@...ian.org>
Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>
---
 fs/configfs/dir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c
index 6d4a1190f694fe5260577dbedeb755d6fcdf6703..ebf32822e29bed882c4204c71b1b3b4e5df2f2bd 100644
--- a/fs/configfs/dir.c
+++ b/fs/configfs/dir.c
@@ -619,7 +619,7 @@ static int populate_attrs(struct config_item *item)
 				break;
 		}
 	}
-	if (t->ct_bin_attrs) {
+	if (!error && t->ct_bin_attrs) {
 		for (i = 0; (bin_attr = t->ct_bin_attrs[i]) != NULL; i++) {
 			if (ops && ops->is_bin_visible && !ops->is_bin_visible(item, bin_attr, i))
 				continue;

-- 
2.34.1